Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

JavaScript jQuery Basics (2014) Creating a Mobile Drop Down Menu Using each()

Kevin Chau
Kevin Chau
5,874 Points

Can someone evaluate this for me? It isn't passing.

I'm reviewing Jquery and found that this particular challenge isn't allowing my to pass this freshly written code, but it does allow me to pass a code I copy/paste from my own files.

I don't know if I did something wrong or if its the system. To code is verbatim.

js/app.js
//Problem: It look gross in smaller browser widths and small devices
//Solution: To hide the text links and swap them out with a more appropriate navigation

//Create a select and append to #menu
var $select = $("<select></select>");
$("#menu").append($select);

//Cycle over menu links
$("#menu a").each(function() {
  var $anchor = $(this);
    //Create an option
  var $option = ("<option></option>");
   //option's value is the href
  $option.val($anchor.attr("href"));
  //option's text is the text of link
  $option.text($anchor.text());
     //append option to select
  $select.append($option);
})
index.html
<!DOCTYPE html>
<html>
<head>
<link rel="stylesheet" href="css/style.css" type="text/css" media="screen" title="no title" charset="utf-8">
</head>
<body>
    <div id="menu">
        <ul>
            <li class="selected"><a href="index.html">Home</a></li>
            <li><a href="about.html">About</a></li>
            <li><a href="contact.html">Contact</a></li>
            <li><a href="support.html">Support</a></li>
            <li><a href="faqs.html">FAQs</a></li>
            <li><a href="events.html">Events</a></li>
        </ul>
    </div>
    <h1>Home</h1>
    <p>This is the home page.</p>
    <script src="//code.jquery.com/jquery-1.11.0.min.js" type="text/javascript" charset="utf-8"></script>
    <script src="js/app.js" type="text/javascript" charset="utf-8"></script>
</body>
</html>

2 Answers

Merritt Lawrenson
Merritt Lawrenson
13,477 Points

For this challenge, you only need to use the each method and pass in an empty anonymous function.

//Problem: It look gross in smaller browser widths and small devices
//Solution: To hide the text links and swap them out with a more appropriate navigation

//Create a select and append to #menu
var $select = $("<select></select>");
$("#menu").append($select);

//Cycle over menu links
$("#menu a").each(function () {

});

The problem with your extended answer is that you're missing a $ in line 12 of your JS. Your code reads:

var $option = ("<option></option>");

but should read:

var $option = $("<option></option>");

Hi Kevin,

One of the expressions is missing a $ in front. The quiz should have loaded with this already in place.

// before change
var $option = ("<option></option>");

// after change
var $option = $("<option></option>");

Hope this helps,

Cheers