Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Android Android Fragments Managing Fragments Fragment Flavors

Posted by Tafadzwa Nyazorwe
Tafadzwa Nyazorwe
17,053 Points

can someone help

I created a new fragment to store our news items. It's called NewsItemFragment.java. When I went to add a constructor to pass in the selected index, Android Studio told me that I shouldn't do that.

Can you please help me by using a bundle to pass the index to my new NewsItemFragment when it is selected? (I added a constant key for the index in NewsItemFragment.java code below

MainActivity.java 
public class MainActivity extends AppCompatActivity implements NewsFragment.NewsListener {
    // New tags for referring to fragments
    public static final String NEWS_FRAGMENT = "news_fragment";
    public static final String NEWSITEM_FRAGMENT = "newsitem_fragment";

    Fragment savedFragment;
    @Override
    public void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);

        FragmentManager fragmentManager = getFragmentManager();

        //NewsFragment savedFragment = (NewsFragment) fragmentManager.findFragmentById(R.id.placeholder);
        savedFragment = fragmentManager.getFragmentManager("NEWS_FRAGMENT");

      //FragmentManager fm = getSupportFragmentManager();
    //fragment = fm.findFragmentByTag("myFragmentTag");


        if (savedFragment == null) {
            NewsFragment newsFragment = new NewsFragment();
            FragmentTransaction fragmentTransaction = fragmentManager.beginTransaction();
            fragmentTransaction.add(R.id.placeholder, newsFragment,"NEWS_FRAGMENT");
            fragmentTransaction.commit();

          //getFragmentManager().beginTransaction().replace(R.id.MainFrameLayout,fragmentA,"YOUR_TARGET_FRAGMENT_TAG").addToBackStack("YOUR_SOURCE_FRAGMENT_TAG").commit(); 

        }

    }

    @Override
    public void onNewsItemSelected(int index) {
        NewsItemFragment fragment = new NewsItemFragment();
        // TODO: how do we pass arguments to the new Fragment?
        FragmentManager fragmentManager = getFragmentManager();
            Bundle bundle = new Bundle();
             FragmentTransaction fragmentTransaction = fragmentManager.beginTransaction();
                bundle.putInt(NewsItemFragment.KEY_NEWS_ITEM_INDEX,0); 
               fragment.setArguments(bundle);

        fragmentTransaction.replace(R.id.placeholder, fragment, "NEWSITEM_FRAGMENT");
        fragmentTransaction.addToBackStack(null);
        fragmentTransaction.commit();
    }
}
NewsItemFragment.java 
public class NewsItemFragment extends Fragment {
    public static final String KEY_NEWS_ITEM_INDEX = "news_item_index";

    @Override
    public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
        // TODO:  Hmmm, how do we get this index?
        int index = getArguments().getInt(KEY_NEWS_ITEM_INDEX) ;
        getActivity().setTitle(News.headlines[index]);
        View view = inflater.inflate(R.layout.fragment_newsitem, container, false);
        return view;
    }





    @Override
    public void onStop() {
        super.onStop();
        getActivity().setTitle(getResources().getString(R.string.app_name));
    }
}
News.java 
public class News {
    public static String[] headlines = new String[]{
      "Treehouse student develops #1 App in Google App Store",
      "Oracle and Google decide to hug it out",
      "Java8 coming to Android!  Is it too late?"
    };
}

1 Answer

D mk
D mk
13,225 Points
D mk
D mk
13,225 Points

You should instead a static method to get the fragment. Something like...

private int index;

public static NewsItemFragment newInstance(int index) {
    NewsItemFragment myFragment = new NewsItemFragment();

    Bundle args = new Bundle();
    args.putInt(KEY_NEWS_ITEM_INDEX, index);
    myFragment.setArguments(args);

    return myFragment;
}