Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

Python

Chase Frankenfeld
Chase Frankenfeld
6,137 Points

Can someone please check to see why my letter game (refined version) isn't working correctly. Appreciated. Thanks :)

Here is my code for the letter game. Not sure why it isn't working. Code:

import random

import os

import sys

# make a list of words
words = [
    'squat',
    'snatch',
    'clean',
    'jerk',
    'handstand',
    'rowing',
    'running',
    'barbell',
    'bumpers'
]

def clear():
    if os.name == 'nt':
        os.system('cls')
    else:
        os.system('clear')

def draw(bad_guesses, good_guesses, secret_word):
    clear()


    print("Strikes: {}/7".format(len(bad_guesses)))
    print('')  

    for guess in bad_guesses:
        print(guess, end=' ')
    print('\n\n')

    for guess in secret_word:
        if guess in good_guesses:
            print(guess, end=' ')
        else:
            print('_', end=' ')

    print('')

def get_guess(bad_guesses, good_guesses):
    while True:    
        # take guesses
        guess = input("Guess a letter: ").lower()

        if len(guess) != 1:
            print("You can only guess a single letter")
        elif guess in bad_guesses or guess in good_guesses:
            print("You already guessed that letter")
        elif not guess.isalpha():
            print("You can only print letters")
        else:
            return guess

def game(done): 
    clear()
    secret_word = random.choice(words)
    bad_guesses = []
    good_guesses = []  

    while True:
        draw(good_guesses, bad_guesses, secret_word)
        guess = get_guess(bad_guesses, good_guesses)

        if guess in secret_word:
            good_guesses.append(guess)
            found = True
            for letter in secret_word:
                if letter not in good_guesses:
                    found = False
            if found:
                print("You win!! The word was {}".format(secret_word))
                done = True
        else:
            bad_guesses.append(guess)
            if len(bad_guesses) == 7:
                draw(good_guesses, bad_guesses, secret_word)
                print("You lost!!")
                print("Your secret word was {}".format(secret_word))
                done = True

        if done:
            play_again = input("Play again? Y/n ").lower()
            if pay_again.lower() != 'n':
                return game(done=False)
            else:
                sys.exist()

def welcome():
    print ('Welcome to the letter guessing game')
    start = input("Press enter/return to start, or Q to quit" )
    if start.lower() == 'q':
        print("bye")
        sys.exit()
    else:
        return True



done = False

while True:
    clear()
    welcome()
    game(done)

Fixed formatting

1 Answer

Chris Freeman
MOD
Chris Freeman
Treehouse Moderator 68,227 Points

There are two typos:

        if done:
            play_again = input("Play again? Y/n ").lower()
            if pay_again.lower() != 'n':
                return game(done=False)
            else:
                sys.exist()        if done:
            play_again = input("Play again? Y/n ").lower()
            if pay_again.lower() != 'n':  # <-- pay_again Not defined
                return game(done=False)
            else:
                sys.exist() # <-- sys.exit()

You also have a positional argument order problem in call to draw function:

# draw function definition:
def draw(bad_guesses, good_guesses, secret_word):

# Call from game()
    while True:
        draw(good_guesses, bad_guesses, secret_word)  # <-- good and bad reversed
Chris Freeman
Chris Freeman
Treehouse Moderator 68,227 Points

Found another bug. Seems to work well after it's fixed. Answer updated.

Chase Frankenfeld
Chase Frankenfeld
6,137 Points

Thanks again Chris. As I can see, I clearly need to pay a lot more attention to the small details. It is definitely something I will take forward as I continue trying to learn.

Also, I have only been a Treehouse user for a short period of time, and this community is very helpful and generous with their time to help new persons.

Thank you