Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

JavaScript Object-Oriented JavaScript Getters and Setters Creating Setter Methods

Zeke Swanson
seal-mask
.a{fill-rule:evenodd;}techdegree
Zeke Swanson
Web Development Techdegree Student 6,532 Points

Can someone please let me know where I'm messing up in the code?

I'm not sure where I'm messing up at.

creating_setters.js
class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }

    stringGPA() {
        return this.gpa.toString();
    }

    get level() {
        if (this.credits > 90 ) {
            return 'Senior';
        } else if (this.credits > 60) {
            return 'Junior';
        } else if (this.credits > 30) {
            return 'Sophomore';
        } else {
            return 'Freshman';
        }
    }

  set major(major) {

    this._major = 'major';

    if (this.credits === 'Senior' || this.credits === 'Junior' ) {
      return this._major;
    }

    else {
      this._major = 'none';
      return this._major;


    }




  }


}

var student = new Student(3.9, 60);

1 Answer

In the line this._major = 'major';, you are setting this._major to the string 'major' rather than the value of the parameter major.

In the line if (this.credits === 'Senior' || this.credits === 'Junior' ) {, this.credits refers to the number of credits that a Student has. You could replace this.credits with this.level to compare a string with a string.

You don't need to return anything in the setter method.