Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

General Discussion

Omer Asadullah
Omer Asadullah
10,415 Points

Can the teachers check my work

I have recently re created Smell's like bakin' with some different approach regarding positioning of elements. Can the teachers check my work Please!

Ok Here is the new link to code pen as suggested

http://codepen.io/anon/pen/ucwLb

@nickpettit

4 Answers

Hi Omer Asadullah Sipra, I'd suggest tagging the teachers by using the @ symbol.

Can I also suggest that you throw the code up on Codepen? That generally makes code easier to review especially considering the local image paths like img/some-image.jpg. One trick could be to host the images on [imgur](imgur.com) and use paths like <img src="http://imgur.com/some-image.jpg"></img>. This could allow you to build a whole CodePen for review and I think it'll allow others to give you better feedback!

Nick Pettit
STAFF
Nick Pettit
Treehouse Teacher

Hi Omer Asadullah Sipra,

I just checked out your Codepen link and everything looks pretty good to me! Nice work. :) Was there something more specific you had a question about?

Omer Asadullah
Omer Asadullah
10,415 Points

Well Thanks for checking my work. There are two things I want to ask. Am I correct in treating the style.css file i.e. Have I properly used the properties to position elements. In the videos for making a simple website, you didn't use margin to a greater extent. Most of the things were handled by grid.css. However, I had to use position and margin properties despite of using same classes in grid css. Is my work in style css appropriate and according to W3C CSS standards.

Secondly I am doing another project currently and things don't tend to move by position and margin properties. Actually, I guess I have understood that grids place objects in columns. However, moving and positioning objects in appropriate places is becoming difficult.

Nick Pettit
Nick Pettit
Treehouse Teacher

Hi Omer Asadullah Sipra,

It looks like you're using position "none" which isn't a valid value for the position property. Two things I recommend:

Omer Asadullah
Omer Asadullah
10,415 Points

Hi Nick. Thanks for your feedback. Actually I used none for the position because whenever I was defining margin properties for positioning elements, nothing was happening. However, when I used none in position things started to work to some extent. I don't know what the problem is. Can you guide me in this.

Omer Asadullah
Omer Asadullah
10,415 Points

Ok I don't know what happened. Maybe I have been mistaken. I removed position properties and I see nothing has changed. All the elements are correctly positioned. Ok thanks for your feedback.