Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

General Discussion

Warren EURICLIDE
Warren EURICLIDE
6,234 Points
Posted by Warren EURICLIDE
Warren EURICLIDE
6,234 Points

Can you critique my Tribute page?

Hello, I'm a beginner, I created this little tribute page and tried to make it responsive. I just want some critiques on it so I can improve : https://codepen.io/W-D-E/pen/YNNzoO

3 Answers

Steven Parker
Steven Parker
229,788 Points
Steven Parker
Steven Parker
229,788 Points

Very nice looking page!

The dynamic scaling during page resizing seems to work well.

The only suggestion that comes to mind is you might make the images keep their aspect ratios as they change size, but even as-is the distortion is reasonably subtle.

Warren EURICLIDE
Warren EURICLIDE
6,234 Points
Warren EURICLIDE
Warren EURICLIDE
6,234 Points

Thank you for your answer! Yes, tried to do that. I still don't understand the background-size property very well :/

Steven Parker
Steven Parker
229,788 Points
Steven Parker
Steven Parker
229,788 Points

I didn't peruse the code, but usually if you scale only the width, the height will remain proportional.

Warren EURICLIDE
Warren EURICLIDE
6,234 Points
Warren EURICLIDE
Warren EURICLIDE
6,234 Points

Oh yes, thank you for the knowledge :) I did put both values. I'll try to change that