Can you make this game better?

Question

I've written some code for a number guessing game - everyone is welcome to use it!

For my first solo project I'm feeling pretty proud! Still, I know there's a lot of ways it could be improved (maybe some things could be condensed, some things could be changed to show it's aware the number is > or <, etc.), and I'm not versed enough to know how; so my fellow tree-housers: who wants to take a crack at it?

name = input("Hello - what's your name?     ")
initial_response = input("Nice to meet you {}; would you like to play a game?    ".format(name))
if initial_response == "yes":
    print("Great, let's get started!")
else:
    print("C'mon - think about saying, 'yes'! Practice is always good!")
try_again = input("So - {}.... \nWould you like to play a game?    ".format(name))
if try_again == "yes":
    print("Awesome - thanks for reconsidering, {}; let's get started!!".format(name), "\nSo {}, I'm thinking of a number between 1-100...".format(name))
else:
    print("I'll go ahead - see if you can keep up!!! \nI'm thinking of a number between 1-100...")
first_answer = input("Can you guess what number it is?    ")
first_answer = int(first_answer)
correct_answer = first_answer == 82
if correct_answer:
    print("Way to go! That's the number I was thinking of!!!")
else:
    print("Good guess but not quite! The number I'm thinking of is bigger than 50.")
second_answer = input("Guess (another) number bigger than 50:     ")
second_answer = int(second_answer)
correct_answer = second_answer == 82
if correct_answer:
    print("Way to go! That's exactly right!!!!")
else:
    print("Oooh! Another good guess {}, but not quite there!".format(name), "The number I'm thinking consists of 2 digits...\nWhen you add them together, it makes 10...\nIt's bigger than 73...")
third_answer = input("What is the number?   ")
third_answer = int(third_answer)
correct_answer = third_answer == 82
if correct_answer:
    print("You got it this time! Good game {}!!!".format(name))
else:
    print("Almost there! Remember: this number has 2 digits that add to 10...\nIt's bigger than 73... and I'll give you another hint!\nIt's not 91...")
fourth_answer = input("You got it now? What's the number?   ")
fourth_answer = int(fourth_answer)
correct_answer = fourth_answer == 82
if correct_answer:
    print("YES! You got it! Nice game :)")
else:
    print("Nope - it was 82! Better luck next time {}!".format(name))

Answer 1 · 2018-10-28T05:49:53Z

October 28, 2018 5:49am

When are asking them if they want to play a game, you should change the initial_response variable to all lower cases (initial_response.lower()) and check if "yes" is contained inside that string ("yes" in initial_response.lower()). Right now, your code only accepts "yes" as a valid answer. With this change, your code will ignore upper cases and punctuation. That way, the user can type "Yes" or "yes." or "YES!!!" and the code will accept it.

As you said, you could use the >, <, >=, <= operators to tell the user if their guess is too high or too low. But you could also ignore invalid guesses. For example, if the user enters 150, you can tell them their answer is not valid and ask them to try again.

Your correct_answer is useless. If you put boolean operators in the argument, the if statement will use the result of that operation. In other words, you should do your comparison directly into the if statement instead of creating a variable and storing the result.

Instead of repeating your code over and over again, you could use a for loop. You haven't seen those yet, but every time the program reaches the end of the block, a variable is incremented (increased by 1). The loop ends when the variable has reached a pre-determined value. For examples, if you assigned this value to be 4 and put your code for guessing in the loop, after 4 tries the loop would end and the user would lose.

You haven't seen that yet, but you could use a random number generator (RNG) instead of using the same number every time. A simple way of doing that would be referring to a method like time.time() and taking the modulo of that (time.time() % 100). That value would be considered random since it is nearly impossible to predict.

Note: x % 100 will give you a value between 0 and 99. You should use (x % 100) + 1 to adjust the range.

Note2: You also need to include the time module using "import time"

Finally, and most importantly, you should make your code more readable. Separate the different sections of your code with spaces and add comments to tell the reader what your are doing or what your logic is. To insert a comment in Python, you simply need to type "#" at the beginning of a line and the whole line will become a comment. Comments are highlighted in green and are ignored by the program.

Answer 2 · 2019-01-18T09:35:03Z

January 18, 2019 9:35am

Nice game Chandelor Simon. Note that I am not a beginner, so don't get discourage if you think my program is advanced.

As Samuel Savaria said this game needs to be done with a loop. I did like the way you said the two numbers added to 10, kinda gives you the answer but is nice. A few things I didn't implement in my program is hints, you could add another function that breaks numbers apart like you did for 8 + 2 = 10. You could add another function to count the number of guesses before you get hints, etc. This game is really fun and there are tons of things you can do with it. The obvious way would be with random class. Let me know if you have any questions regarding the code.

    import random

    def yes_or_no(question):
        while "the answer is invalid":
            reply = str(input(question+' (y/n): ')).lower().strip()
            if reply[0] == 'y':
                return True
            if reply[0] == 'n':
                return False

    name = input("Hello - what's your name? ")
    is_playing_game = yes_or_no("Would you like to play a game?")
    is_answer_correct = False

    if not is_playing_game:
        print("\nOkay - maybe next time! You can always type this to play the game:\n")

    # game loop
    while is_playing_game:
        random_num = random.randint(1, 100)
        print("\nGreat, let's get started!\n\nI'm thinking of a number between 1 and 100...")
        first_answer = input("Can you guess what number it is? ")

        while not is_answer_correct:
            # Number changed from string to integer.
            first_answer = int(first_answer)

            # Determines if the number picked by user is random_num, higher, or lower; if incorrect - gives hint.
            if first_answer == random_num:
                is_answer_correct = True
                print("\nWay to go! That's the number I was thinking of!!!\n")
            elif first_answer > random_num:
                print("\nGood guess - but not quite! The number I'm thinking of is less than that.")
            elif first_answer < random_num:
                print("\nGood guess - but not quite! The number I'm thinking of is higher than that.")
            else:
                print("\nThat's not a valid guess; the number I'm thinking of is between 1-100\nTry again!")

            first_answer = input("Can you guess what number it is? [options: exit] ")

            # break out of inner while loop
            if first_answer == "exit":
                is_playing_game = False
                break

    print("Thank you for playing {}".format(name))

Welcome to the Treehouse Community

Looking to learn something new?

Chandelor Simon

Chandelor Simon

Can you make this game better?

Samuel Savaria

Samuel Savaria

2 Answers

Samuel Savaria

Samuel Savaria

Chandelor Simon

Chandelor Simon

Chandelor Simon

Chandelor Simon

Samuel Savaria

Samuel Savaria

Chandelor Simon

Chandelor Simon

Samuel Savaria

Samuel Savaria

Fernando Balandran

Fernando Balandran

boi

boi