Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python

Cannot set the discount to zero for a user without the 'can_give_discount' permission

I am having trouble trying to get this to work. The attached code under the form_valid method is my attempt to this challenge. But the error reports that a user without the right permission created a discounted product. Is there any way to resolve this issue?

products/models.py from django.core.urlresolvers import reverse from django.db import models

class Product(models.Model): name = models.CharField(max_length=255) description = models.TextField() price = models.DecimalField() discount = models.DecimalField(blank=True, null=True)

class Meta:
    permissions = (
        ('can_give_discount','gives discount'),
    )

def __str__(self):
    return self.name

def get_absolute_url(self):
    return reverse("products:detail", kwargs={"pk": self.pk})

products/views.py from django.contrib.auth.mixins import LoginRequiredMixin from django.views import generic

from . import models

class List(generic.ListView): model = models.Product

class Detail(generic.DetailView): model = models.Product

class Create(LoginRequiredMixin, generic.CreateView): fields = ("name", "description", "discount", "price") model = models.Product

def form_valid(self, form):
    if(not self.request.user.has_perm('model.can_give_discount')):
        self.object = form.save()
        self.object.discount = 0
        return HttpResponseRedirect(self.get_success_url())