Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Data Structures Exploring the Java Collection Framework ArrayLists

Naval Kulkarni
Naval Kulkarni
13,782 Points

Can't find the links

Please tell what is wrong with this code.

com/example/BlogPost.java
package com.example;

import java.io.Serializable;
import java.util.Date;
import java.util.*;

public class BlogPost implements Comparable<BlogPost>, Serializable {
  private String mAuthor;
  private String mTitle;
  private String mBody;
  private String mCategory;
  private Date mCreationDate;

  public BlogPost(String author, String title, String body, String category, Date creationDate) {
    mAuthor = author;
    mTitle = title;
    mBody = body;
    mCategory = category;
    mCreationDate = creationDate;
  }

  public int compareTo(BlogPost other) {
    if (equals(other)) {
      return 0;
    }
    return mCreationDate.compareTo(other.mCreationDate);
  }

  public List<String> getExternalLinks(){
    List<String> list=new ArrayList<>();
    for(String word:getWords())
    {
        if(word.equals("http"))
        list.add(word);
    }
    return list;
  }

  public String[] getWords() {
    return mBody.split("http");
  }

  public String getAuthor() {
    return mAuthor;
  }

  public String getTitle() {
    return mTitle;
  }

  public String getBody() {
    return mBody;
  }

  public String getCategory() {
    return mCategory;
  }

  public Date getCreationDate() {
    return mCreationDate;
  }
}

1 Answer

The challenge states all words that start with http should be considered links. You have used word equals http in your method. Try startsWith instead.

public List<String> getExternalLinks(){
    List<String> list=new ArrayList<>();
    for(String word:getWords())
    {
        if(word.startsWith("http"))
        list.add(word);
    }
    return list;
  }

Also get words doesn't need to be changed. This:

public String[] getWords() {
    return mBody.split("http");
}

should be:

public String[] getWords() {
    return mBody.split("\\s+");
}