Java Java Objects Delivering the MVP Applying a Discount Code

Catch block not working??

I can't seem to figure out why my catch block is not working?? The tester is producing the following error:

Bummer: Hmmm...I ran order.applyDiscountCode("h1!") and I expected it to throw an IllegalArgumentException, but it didn't

Order.java
public class Order {
  private String itemName;
  private int priceInCents;
  private String discountCode;

  public Order(String itemName, int priceInCents) {
    this.itemName = itemName;
    this.priceInCents = priceInCents;
  }

  private String normalizeDiscountCode(String discountCode) {
    char[] charList = discountCode.toCharArray();
    for (char c : charList) {
      if (!Character.isLetter(c) && c!='$') {
        throw new IllegalArgumentException("Invalid discount code");
      }
    }
    return discountCode.toUpperCase();
  }

  public String getItemName() {
    return itemName;
  }

  public int getPriceInCents() {
    return priceInCents;
  }

  public String getDiscountCode() {
    return discountCode;
  }

  public void applyDiscountCode(String discountCode) {
    try {
    this.discountCode = normalizeDiscountCode(discountCode);
    } catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());
    }
  }
}
Example.java
public class Example {

  public static void main(String[] args) {
    // This is here just for example use cases.

    Order order = new Order(
            "Yoda PEZ Dispenser",
            600);

    // These are valid.  They are letters and the $ character only
    order.applyDiscountCode("abc");
    order.getDiscountCode(); // ABC

    order.applyDiscountCode("$ale");
    order.getDiscountCode(); // $ALE


    try {
      // This will throw an exception because it contains numbers
      order.applyDiscountCode("ABC123");
    } catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }
    try {
      // This will throw as well, because it contains a symbol.
      order.applyDiscountCode("w@w");
    }catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }

  }
}

1 Answer

saykin
saykin
9,820 Points

In this instance Craig wants the program to terminate if wrong values are passed on. If you remove your try/catch block and just keep

this.discountCode = normalizeDiscountCode(discountCode);

It should pass.

Catching an exception will stop the application from terminating.