JavaScript JavaScript and the DOM Getting a Handle on the DOM Practice Selecting Elements

Challenge Task 1

I've tried every combination of things and been on MDN and just cannot get this to work. Can you please help?

I've tried every derivation. I've even looked up running it on specific variables.

Can you please show me what the code should look like so I can see where I've gone wrong/

js/app.js
let navContainer = document.querySelector('nav');
let navigationLinks = navContainer.querySelectorAll("li");
let galleryLinks;
let footerImages;
index.html
<!DOCTYPE html>
<html>
  <head>
    <meta charset="utf-8">
    <title>Nick Pettit | Designer</title>
    <link rel="stylesheet" href="css/normalize.css">
    <link href='http://fonts.googleapis.com/css?family=Changa+One|Open+Sans:400italic,700italic,400,700,800' rel='stylesheet' type='text/css'>
    <link rel="stylesheet" href="css/main.css">
    <link rel="stylesheet" href="css/responsive.css">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
  </head>
  <body>
    <header>
      <a href="index.html" id="logo">
        <h1>Nick Pettit</h1>
        <h2>Designer</h2>
      </a>
      <nav>
        <ul>
          <li><a href="index.html" class="selected">Portfolio</a></li>
          <li><a href="about.html">About</a></li>
          <li><a href="contact.html">Contact</a></li>
        </ul>
      </nav>
    </header>
    <div id="wrapper">
      <section>
        <ul id="gallery">
          <li>
            <a href="img/numbers-01.jpg">
              <img src="img/numbers-01.jpg" alt="">
              <p>Experimentation with color and texture.</p>
            </a>
          </li>
          <li>
            <a href="img/numbers-02.jpg">
              <img src="img/numbers-02.jpg" alt="">
              <p>Playing with blending modes in Photoshop.</p>
            </a>
          </li>
        </ul>
      </section>
      <footer>
        <a href="http://twitter.com/nickrp"><img src="img/twitter-wrap.png" alt="Twitter Logo" class="social-icon"></a>
        <a href="http://facebook.com/nickpettit"><img src="img/facebook-wrap.png" alt="Facebook Logo" class="social-icon"></a>
        <p>&copy; 2016 Nick Pettit.</p>
      </footer>
    </div>
  <script src="js/app.js"></script>
  </body>
</html>

3 Answers

Jennifer Nordell
STAFF
Jennifer Nordell
Treehouse Staff

Hi there, Nicholas Dunn ! Looks like you're doing terrific! My guess here is that there is a misunderstanding of the instructions. You are meant to get the links. Now, it could also be that it's just easy to look at "li" and immediately think "link". But an <li> is for a list item. The link is our anchor tag or <a>.

So keeping all the rest of your code the same, if I change out "li" for "a" your code passes the first step with flying colors! :sparkles:

Mark Wilkowske
MOD
Mark Wilkowske
Treehouse Moderator 16,279 Points

Hi Nicholas, this challenge tests understanding of the method that can grab multiple elements, a collection of elments, which is none other than .querySelectorAll(). For Task 1 this is the descendant selector: 'nav a' or links that are within <nav>. Tasks 2 and 3 test how you select links and elements in other contexts. Hope this helps out and have a great day!

Thanks everyone!