Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript Basics (Retired) Creating Reusable Code with Functions Create a max() Function

Billy Chui
Billy Chui
6,852 Points

challenge task 1 create a max()

hi there, someone please help with this challenge

script.js
function max(num1, num2) {
  var total = num1 + num2;
  if (total > num1 && total > num2) {
    return true;
  } else {
    return false;
}

  console.log(max(12, 13));
Billy Chui
Billy Chui
6,852 Points

function max(num1, num2) { if(num1 > num2){ return num1; }else { return num2; } } max( 10, 20);

got it right finally, the question is so confusing

2 Answers

Steven Parker
Steven Parker
231,172 Points

As you discovered, you don't need to add the numbers together. You only need to compare them with each other, and then return the one that is larger.

Note that when an "if" code block ends with a "return", you don't need an "else" afterwards since that code can only be reached when the condition is false.

Billy Chui
Billy Chui
6,852 Points

thanks very much Steven!!!