Change the stroke of the circles

Question

what am i doing wrong? i used the existing code from the fill style to model the stroke function but now task 1 isnt passing

js/app.js

// height and width of the svg
var height = 800, width = 500;

var padding = 50;

var viz = d3.select("#viz-wrapper")
    .append('svg')
    .attr('id', 'viz')
    .attr('height', height)
    .attr('width', width);

d3.csv('app/climate_data_truncated.csv', function(data) {

    dots = viz.selectAll('circle')
        .data(data)
        .enter()
        .append('circle');

    dots.attr('r', function(d) {return Math.abs(d.TMAX) / 10})
        .attr('cx', function(d) {return Math.max(0 + padding, Math.random() * width - padding)})
        .attr('cy', function(d) {return Math.max(0 + padding, Math.random() * height - padding )})
        .style('stroke', function(d) {
            year = d.DATE.substring(0,3)
            if (year === "1973") {
                return "red"
            }
            else {
                return "#ff00f5"
            }
        });
        .style('fill', function(d) {
            year = d.DATE.substring(0,4)
            if (year === "1973") {
                return "blue"
            }
            else {
                return "#ff00f5"
            }
        });
});

index.html

<!DOCTYPE html>
<html>
  <head>
    <meta charset="UTF-8">
    <title>Requests</title>
  </head>
  <body>
    <div id="viz-wrapper">
    </div>
  </body>
  <script src="js/d3.min.js" charset="utf-8"></script>
  <script src="js/app.js" charset="utf-8"></script>
</html>

Answer 1 · 2017-10-19T16:48:03Z

October 19, 2017 4:48pm

There's a few issues with the code change:

somehow you managed to un-do task 1 (where you changed the radius to use TMIN) which must be re-done
the arguments to substring got modified and are incorrect in the copy
there's now a stray extra semicolon between the two style method calls

Welcome to the Treehouse Community

Looking to learn something new?

Scott Glover

Scott Glover

Change the stroke of the circles

1 Answer

Steven Parker

Steven Parker