Changing method implementation by loadUserByUsername(String str)

Question

Is any difference to using THIS implementation in loadUserByUsername method:

User user = findByUsername(username);

instead of :

User user = userDao.findByUsername(username);

cause we already have this implementation in our class. THe full code is here:

@Override
    public User findByUsername(String username) {
        return userDao.findByUsername(username);
    }

    @Override
    public UserDetails loadUserByUsername(String username) throws UsernameNotFoundException {
            User user = findByUsername(username); 
//OR MAYBE SO:
           User user = userDao.findByUsername(username)
        if(user == null) {
            throw new UsernameNotFoundException("User not found");
        }

        return user;
    }

Answer 1 · 2016-08-19T19:45:10Z

August 19, 2016 7:45pm

I think there it depends whether you want to call userDao.findByUsername or userService.findByUsername. If they are the same like in your case. It does not matter, but they can be different. For example: userService.findByUsername can check if user is admin, but userDao.findByUsername just retireves values. In this case you have to decide whether in the method you want to use userDao method, without checking admin rights, or userService method with additional security check

Welcome to the Treehouse Community

Looking to learn something new?

Sergei Makarov

Sergei Makarov

Changing method implementation by loadUserByUsername(String str)

1 Answer

Alexander Nikiforov

Alexander Nikiforov