Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Objects Creating the MVP Current Progress

Posted by Yashvir Sangha
Yashvir Sangha
620 Points

Checking isHit incorrectly causing incorrect looping

No matter what correct answer I input the output is always tree----e, even if I type h, o, u or s. Here is my code:

-------Game.java:

class Game {
  private String answer;
  private String hits;
  private String misses;

  public Game(String answer){
    this.answer = answer;
    hits = "";
    misses = "";
  }
  public boolean applyGuess(char letter){
    boolean isHit = answer.indexOf(letter) != -1;
    if (isHit) {
      hits += "letter";
    } else {
      misses += "letter";
    }
    return isHit;
  }

  public String currentGuesses(){
    String progress = "";
    for (char letter : answer.toCharArray()){
      char display = '-';
      if(hits.indexOf(letter) != -1){
         display = letter;
      }
      progress += display;
    }
    return progress;
  }
}

--------Prompter.java:

import java.util.Scanner;

class Prompter {
  private Game game;

  public Prompter(Game game) {
    this.game = game;
  }

  public boolean promptForGuess() {
    Scanner scanner = new Scanner(System.in);
    System.out.print("Enter a letter:");
    String guessInput = scanner.nextLine();
    char guess = guessInput.charAt(0);
    return game.applyGuess(guess);
  } 

  public void displayProgress() {
    System.out.printf("Try to solve; %s%n",
                      game.currentGuesses());

  }
}

------ Hangman.java:

public class Hangman {

  public static void main(String[] args) {
    // Your incredible code goes here...
    Game game = new Game("treehouse");
    Prompter prompter = new Prompter(game);
    prompter.displayProgress();
    boolean isHit = prompter.promptForGuess();
    if (isHit) {
      System.out.println("We got a hit");
    } else{
      System.out.println("You missed!");
    }
    prompter.displayProgress();
  }
}

2 Answers

Mark Sebeck
MOD
Mark Sebeck
Treehouse Moderator 37,901 Points
Mark Sebeck
Mark Sebeck
Treehouse Moderator 37,901 Points

Hi Yashvir. So close but a tiny typo can make the results so weird it's hard to track down.

In your game class look at the applyGuess method

public boolean applyGuess(char letter){
    boolean isHit = answer.indexOf(letter) != -1;
    if (isHit) {
      hits += "letter";
    } else {
      misses += "letter";
    }
    return isHit;
  }

hits += "letter"; - will add the string "letter" to hits. Instead you want to add what is stored in the variable letter. Just delete the quotes and it will work as expected.

public boolean applyGuess(char letter){
    boolean isHit = answer.indexOf(letter) != -1;
    if (isHit) {
      hits += letter;
    } else {
      misses += letter;
    }
    return isHit;
  }

In the string "letter" you have matching e, r and t. So that is why you are getting the results you are. Good luck and keep going to finish the game.

Yashvir Sangha
Yashvir Sangha
620 Points
Yashvir Sangha
Yashvir Sangha
620 Points

Thanks so much! I spent so much time trying to figure it out.