Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python

akhter ali
akhter ali
15,778 Points
Posted by akhter ali
akhter ali
15,778 Points

classmethod confusion

I've created my class method which returns a list of the converted "dash" or "dot". Judging by the question, this is what it is supposed to return, in the order it was input to the class. However it still reports it didn't get the "right" output. This is what I've returned locally. 

>>> test = Letter.from_string("dot-dot")
>>> test.pattern
['.', '.']
>>> test = Letter.from_string("dot-dash")
>>> test.pattern
['.', '-']
>>> type(test.pattern)
<class 'list'>
>>>

I wonder if it's looking for a tuple with a list inside.

morse.py 
class Letter:
    def __init__(self, pattern=None):
        self.pattern = pattern

    def __iter__(self):
        yield from self.pattern

    def __str__(self):
        output = []
        for blip in self:
            if blip == '.':
                output.append('dot')
            else:
                output.append('dash')
        return '-'.join(output)

    @classmethod
    def from_string(cls, string):
        patternList = []
        stringList = string.split('-')
        for item in stringList:
            if item.lower() == 'dash':
                patternList.append('-')
            elif item.lower() == 'dot':
                patternList.append('.')

        return cls(patternList)


class S(Letter):
    def __init__(self):
        pattern = ['.', '.', '.']
        super().__init__(pattern)

1 Answer

andren
andren
28,558 Points
andren
andren
28,558 Points

Despite the name the dash string is actually supposed to be translated to an _ , not a -.

If you fix that discrepancy like this:

class Letter:
    def __init__(self, pattern=None):
        self.pattern = pattern

    def __iter__(self):
        yield from self.pattern

    def __str__(self):
        output = []
        for blip in self:
            if blip == '.':
                output.append('dot')
            else:
                output.append('dash')
        return '-'.join(output)

    @classmethod
    def from_string(cls, string):
        patternList = []
        stringList = string.split('-')
        for item in stringList:
            if item.lower() == 'dash':
                patternList.append('_')
            elif item.lower() == 'dot':
                patternList.append('.')
        return cls(patternList)


class S(Letter):
    def __init__(self):
        pattern = ['.', '.', '.']
        super().__init__(pattern)

Then your code will be accepted.

akhter ali
akhter ali
15,778 Points
akhter ali
akhter ali
15,778 Points

Thanks, this should really be renamed to "Underscore-dot" to avoid confusion perhaps.