Code Challenge Object-Oriented Swift. Stuck with the typ "Location"!

Steve thanks so much for always helping out...def helps !

Hello Steve, can you check whether my code is correct or not? It passed the task:

struct Location {
    let latitude: Double
    let longitude: Double
}

class Business {
    let name: String
    let location: Location

    init(name: String, x: Double, y: Double) {
        self.name = name
        self.location = Location(latitude: x, longitude: y)
    }
}

let someBusiness = Business(name: "Business", x: 2.3, y: 3.2)

Will do... I'll be back in the office soon so I will look then.

Steve.

Hi Djon Sim!

For some reason I'm getting a 404 on the challenge page right now so can't check the wording of the question.

However, from memory, (and bear in mind this post is a year old!) the idea of the task was to pass a Location object into the Business class when instantiating a Business object. That's not what your code does. You have created an elegant solution to work around the problem but your code doesn't actually fit the task in hand, even if the tests of the challenge aren't clever enough to work that out!

So, well done on creating an interesting solution to the challenge, but do think about what the requirements of the task set out before you. Plus, if you omit the init method and set up the Location object within the call for a new Business object, you save on lines of code. While that's not always a good thing, it is often strived for.

Let me know if I can explain that more thoroughly; happy to help.

Steve.

Could not find how to reply to your recent comment ;) Your explanations are quite clear, thanks. The only thing I could not understand is: " if you omit the init method and set up the Location object within the call for a new Business object, you save on lines of code. While that's not always a good thing, it is often strived for."

I am not so good in classes yet, however as I understand it is a must to specify init method, so how can I omit it? ;)

And how will the shorten line of code look like? If I am not asking too much ;)

Hi Djon Sim!

Two things, first of all. 1. apologies; I got some of that answer wrong because I had a different code challenge in mind - I'll correct that now, and, 2, you can never ask too much! Ask away! I love answering questions as it helps me keep fresh too, initmethods aside. So, let's sort out my bad answer first ...

Yes, you are correct, every class needs an init method. So ignore that part of my answer (I had a challenge in mind where there are two structs, not a class - that's why I wanted the challenge link to work!). My bad. I apologise unreservedly.

But the rest of my post remains the same. To instantiate a Business class object, it should take two parameters; a name which is a String and a Location instance. A Location is a struct (which doesn't need an init method ) which requires two Double numbers, as you know. So, when you instantiate your Business object, pass a Location into the init` method.

This looks like:

let someBusiness = Business(name: "The Biz", location: Location(latitude: 3.1, longitude: 58.2))

So, here, we are creating a Location inside the call to the init method of the Business class.

Does that make sense?

Steve.

Yep, it is much clearer now. Thanks a bunch!

Glad to help. Keep up the good work.

Steve.

Hi there,

Your code works OK, yes, in that it creates an instance of Business that contains the correct information - it is an interesting solution in concept; the output is correct.

However, it doesn't meet with the requirements as set out in the challenge. The initializer is expected to be able to handle two parameters, a name string and a Location object. Your code cannot handle those inputs and so will fail the challenge.

It is important to consider the inputs, not just outputs, when creating code. Knowing what you have to work with is critical to deliver the results required. Just creating the correct end-position is not all what it is about - the route you take is also important. Whilst this is a simplistic example, let's say your co-workers in another development team were tasked with generating a Location object to pass to your code; their correctly written output would not match your required inputs because your code is unable to handle the Location object.

Make sense?

Steve.

Hey, no problem!

Hi there,

I don't think the actual name of the business matters. The code needs to handle a name which is a string and a location that's a Location.

Make sense?

Steve.

You haven't assigned the incoming parameter for the name constant inside your init method.

You need to add:

self.name = name

within your initialiser.

You are getting an empty string because you have assigned an empty string to every instance of this class. To fix that, remove the assignment at the top of your class. Just have var name: String rather than assigning an empty string to it.

The final code should look like:

class Business{
  let name: String  // <- remove = ""
  let location: Location

  init(name: String, location: Location){
    self.name = name    // add this
    self.location = location
  }
}

let someBusiness = Business(name: "Biz", location: Location(latitude: 1, longitude: 2))

Steve.

Sorry - just read your post more thoroughly! Your code shouldn't pass the challenge; I will report a bug to the development team. The tests must just look for an output result, rather than expecting the input to match the output.

This post is about Swift 2.0 - that's well out of date. Is the course still live?! I thought they'd been retired?

Which challenge are you having a problem with? I'll try to help.

Steve.

Hiya,

Yes; keep going. Your challenges are the same as we all faced. Ask questions in the forums here - you'll learn loads. Don't put yourself down - be positive, you are doing great already! (No, I'm not paid by Treehouse, I'm just a volunteer)

You can @ mention me, like on Twitter and I'll try to answer your questions. Swift isn't my thing, but I know how to write an iOS app. And this course has been retired on January 15, 2017. I think the forum might link to the same subject but from a different course.

Not to worry - keep asking questions - that's the best way to learn. Check out my profile; I am reachable in many ways, but keeping it in here is the best, for me.

Did you get this challenge passed?

Steve.

Ah - yes, I saw the follow and wondered how the hell we were connected!! If I can help; I will. Just shout.

Steve.