Code inside of constructor wont run?

Question

Here is the object I'm trying to construct:

import java.util.Random;

public class Jar {
  private String mItemName;
  private int mMaxItemNumber;
  private int mNumberOfItems;

  public Jar (String itemName, int maxItemNumber){
    mItemName = itemName;
    mMaxItemNumber = maxItemNumber;
    mNumberOfItems = fill();
    System.out.printf("Number of items in jar: %d", mNumberOfItems);
  }

  private int fill() {
    return Random.nextInt(mMaxItemNumber) + 1;
  }
}

Here is the code calling the constructor:

import java.io.BufferedReader;
import java.io.InputStreamReader;
import java.io.IOException;


public class Prompter{
  private Jar mJar;
  private BufferedReader mReader;

  public Prompter() {
    mReader = new BufferedReader(new InputStreamReader(System.in));
  }

  public void buildJar() {
    try {
      System.out.println("ADMINISTRATOR SETUP");
      System.out.println("======================");
      System.out.print("What type of item should be in the jar:   ");
      String itemName = mReader.readLine();
      System.out.printf("What is the maximum amount of %s:   ",
                       itemName);
      String maxItemNumberAsString = mReader.readLine();
      int maxItemNumber = Integer.parseInt(maxItemNumberAsString.trim());
      mJar = new Jar (itemName, maxItemNumber);
      System.out.println("1");

    } catch(IOException ioe) {
      System.out.println("Problem with input");
      ioe.printStackTrace();
    }
  }
}

Answer 1 · 2017-06-24T14:32:11Z

June 24, 2017 2:32pm

I can see one issue in the fill method:

private int fill() {
    return Random.nextInt(mMaxItemNumber) + 1;
}

nextInt is not a static method, in other words it cannot be called directly on the class it is in. You have to create an instance of the Random class and then call the method through that instance. Like this:

private int fill() {
    Random random = new Random(); // Create Random object
    return random.nextInt(mMaxItemNumber) + 1; // Call nextInt on that object
}

That is the only direct error I can see.

Welcome to the Treehouse Community

Looking to learn something new?

Adam Wilkins

Adam Wilkins

Code inside of constructor wont run?

1 Answer

andren

andren

Adam Wilkins

Adam Wilkins