Code isn't working but gives no errors

Question

var xhr = new XMLHttpRequest();
xhr.onreadystate = function () {
  if(xhr.readyState === 4) {
    var employees = JSON.parse(xhr.responseText);
    console.log(typeof employees);
  }
};
xhr.open('GET', 'data/employees.json');
xhr.send();
Nothing is returned in the js console, not even an error.

Helmut Granda · Accepted Answer

I am not sure what exactly you are trying to do but according to the docs, onreadystate is not an event that is being dispatched by the XMLHttpRequest, however onreadystatechange is. 
https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/onreadystatechange
With that in mind I would change your code as follows:
```javascript
var xhr = new XMLHttpRequest(); 
xhr.onreadystatechange = function () { 
  if(xhr.readyState === 4) { 
    var employees = JSON.parse(xhr.responseText); 
    console.log(typeof employees); 
  } 
};
xhr.open('GET', 'data/employees.json'); 
xhr.send();
```
I would also move checking the typeof employees before parsing it, if the responseText is not a JSON object you will get errors.
I hope this helps.

Welcome to the Treehouse Community

Looking to learn something new?

Anthony Scott

Anthony Scott

Code isn't working but gives no errors

1 Answer

Helmut Granda

Helmut Granda