JavaScript Object-Oriented JavaScript Getters and Setters Creating Getter Methods

Gabrielle Lamarche
Gabrielle Lamarche
8,470 Points

Code not working | JS Getter

I've made it as readable as possible and can't seem to figure out why this isn't giving me the desired values? If anyone has a shorter solution, that would also be helpful! Thank you

creating_getters.js
class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }

    stringGPA() {
        return this.gpa.toString();
    }

    get level () {
        if (this.credits > 90) {
            return 'Senior';
        } else if (this.credits <= 90 && this.credits > 61 ) {
          return 'Junior';
      } else if (this.credits <= 60 && this.credits >= 31) {
            return 'Sophomore';
        } else if (this.credits <= 30) {
                return 'Freshman';
        }
    }
}

const student = new Student(3.9);

1 Answer

Antti Lylander
Antti Lylander
9,644 Points

You should change your last 'else if' to 'else' only. Remember that 'else' does not need any condition.

Or to make it even simpler, just use 'if' for all the lines. In addition, check what your method returns when the student has 61 credits :)

Like this:

if (condition1) {return 'condition 1 is true'}
if (condition2) {return 'condition 2 is true'}

Now, if the first condition will be true, the second will not be checked at all because 'return' exits the code block.