Code Review for Teacher Stats

Question

FINISHED!!!
Would anyone mind giving feedback, if any, on my code for this challenge?
Any criticism is appreciated, thanks!
```python
def mostclasses(teachdict):
  count = 0
  busyteach = None
  for classes in teachdict:
    if len(teachdict[classes]) > count:
      count = len(teachdict[classes])
      busyteach = classes
  return busyteach
def numteachers(teachdict):
  teachcount = len(teachdict.keys())
  return teach_count
def stats(teachdict):
  teachlist = []
  for classes in teachdict:
    innerlist = []
    innerlist.append(classes)
    innerlist.append(len(teachdict[classes]))
    teachlist.append(innerlist)
  return teachlist
def courses(teachdict):
  courselist = []
  for classes in teachdict.values():
    courselist.extend(classes)
  return course_list
```

Jason Anello · Accepted Answer

Hi adudewithaview,
A suggestion on variable naming -
In most_classes() and stats() you've used the variable name classes but you're iterating over the teacher names in the dictionary. It would be more appropriate to use something like teacher to be more descriptive of what it's storing. In courses() it's more appropriate to use classes like you did because you're iterating over the values of the dictionary and those are in fact a list of classes.
I can see a few cases where you could shorten the code a bit or maybe  just an alternative way of doing it.
def mostclasses(teachdict):
Since you need both the key and value inside your loop you could iterate over both the key and value. This makes the code inside the loop a little shorter and possibly more readable depending on personal preference.
python
def most_classes(teach_dict):
  count = 0
  busy_teach = None
  for teacher, classes in teach_dict.items():
    if len(classes) > count:
      count = len(classes)
      busy_teach = teacher
  return busy_teach

def numteachers(teachdict):
The length of a dictionary is the number of keys it has. So you could simply return the length of the dictionary that's passed in.
python
def num_teachers(teach_dict):
  return len(teach_dict)

def stats(teach_dict):
It's not strictly necessary to create the inner_list. Each time through the loop you can append a list consisting of the teacher and number of classes.
python
def stats(teach_dict):
  teach_list = []
  for teacher, classes in teach_dict.items():
    teach_list.append([teacher, len(classes)])
  return teach_list

If you learn about list comprehensions then this function could be even shorter. There's a workshop on comprehensions if you're interested in learning more. Python Comprehensions (https://teamtreehouse.com/library/python-comprehensions)
python
def stats(teach_dict):
  return [[teacher, len(classes)] for teacher, classes in teach_dict.items()]

The code you wrote is fine. These are only suggestions and mostly a matter of personal preference. I hope it helps.

Welcome to the Treehouse Community

Looking to learn something new?

sradms0

sradms0

Code Review for Teacher Stats

1 Answer

Jason Anello

Jason Anello

def most_classes(teach_dict):

def num_teachers(teach_dict):

def stats(teach_dict):

sradms0

sradms0