Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript Loops, Arrays and Objects Simplify Repetitive Tasks with Loops The Refactor Challenge, Part 2

Colin Sandlin
Colin Sandlin
4,512 Points
Posted by Colin Sandlin
Colin Sandlin
4,512 Points

Colors not showing up

var html = '';
var rgbColor;


function colorGenerator() {
  var generatedColor = Math.floor(Math.random() * 256 );
  return generatedColor;
}


function colorCombo() {
  var color = 'rgb(';
  color += colorGenerator() + ',';
  color += colorGenerator() + ',';
  color += colorGenerator() + ')';
  return color;
}

for (var i = 1; i < 11; i++) {
  rgbColor = colorCombo();
  html += '<div style="background-color:' + rgbColor + '"></div>';
}

1 Answer

Dario Bahena
Dario Bahena
10,697 Points
Dario Bahena
Dario Bahena
10,697 Points

Very close. It is missing some padding to show the content. Otherwise, it is just creating divs without sizes.

var html = '';
var rgbColor;


function colorGenerator() {
  var generatedColor = Math.floor(Math.random() * 256 );
  return generatedColor;
}


function colorCombo() {
  var color = 'rgb(';
  color += colorGenerator() + ',';
  color += colorGenerator() + ',';
  color += colorGenerator() + ')';
  return color;
}

// added missing padding so that the divs are visible
for (var i = 1; i < 11; i++) {
  rgbColor = colorCombo();
  html += '<div style="background-color:' + rgbColor + ';padding: 10px;"></div>';
}
// write to the document so content is displayed
document.write(html)