Combat System

Question

Code : https://w.trhou.se/cd0p50wlc3
If you run this application and attack you will be able to attack the enemy , and the enemy will then attack you back but once that action has been done it prints you back the attacking menu without changes on the health of the enemy.
If anyone skilled enough could help me out it'd be much appricated :}

Steven Parker · Accepted Answer

On line 121, you have:
py
        enemy.health = PAttack

:point_right: But you probably meant to write this:
py
        enemy.health -= PAttack

Another issue I found was with these lines 114/115:
py
    PAttack = random.randint(PlayerIG.attack / 2, PlayerIG.attack)
    EAttack = random.randint(PlayerIG.attack / 2, enemy.attack)

The enemy's value is computed from the player, and both cause an error if the attack is an odd number.
You probably want this:
py
    PAttack = random.randint(math.floor(PlayerIG.attack / 2), PlayerIG.attack)
    EAttack = random.randint(math.floor(enemy.attack / 2), enemy.attack)

You'll also need to import math.
And one more issue on line 125:
py
    if enemy.health == 0:

You probably want this:
py
    if enemy.health <= 0:

And there's a similar problem on line 134.

Nicholas Anstis · Answer

Thanks a lot for taking to time to read my code and answer me that fast :} 
Much appriciated :]

Welcome to the Treehouse Community

Looking to learn something new?

Nicholas Anstis

Nicholas Anstis

Combat System

2 Answers

Steven Parker

Steven Parker

On line 121, you have:

But you probably meant to write this:

Nicholas Anstis

Nicholas Anstis