Combo Code challenge question

Question

Hi,

I solved this challenge in two different ways. Both deliver the desired result. However I feel like this could be further improved and made more efficient. Please check out both of my solutions and advice me on what I can improve and what I must NEVER do.

kind regards,

Fahad

solution 1:

def combo(list1, list2):
    list = []

    for (item1, item2) in zip(list1, list2):
        list.append((item1, item2))
    return list    
combo([1, 2, 3], 'abc')

solution 2:

def combo(list1, list2):
    list = []

    for value1, value2 in enumerate(list2):
        list.append((value1+1, value2))
    return list    
combo([1, 2, 3], 'abc')

Answer 1 · 2016-12-19T09:19:14Z

December 19, 2016 9:19am

"Solution 2" does not satisfy the challenge requirements.

It might appear to do the same thing when tested using these particular arguments, but it will not do the same thing with other arguments, and it will not pass the challenge. Try pasting it into the challenge yourself and see! Or test both versions using: combo('abc', [1, 2, 3]) or combo('test', 'this').

As far as what to "NEVER" do: Never assume a single test case is enough to verify the proper operation of a function.

Answer 2 · 2016-12-20T12:52:24Z

December 20, 2016 12:52pm

The key takeaway is in Steven's answer, but regarding your first soution (which is fine), you can also construct a list from the zip object with the built-in list() method, so the whole function body will be just one line:

def combo(list1, list2):
    return list(zip(list1, list2))

Welcome to the Treehouse Community

Looking to learn something new?

fahad lashari

fahad lashari

Combo Code challenge question

2 Answers

Steven Parker

Steven Parker

"Solution 2" does not satisfy the challenge requirements.

gyorgyandorka

gyorgyandorka

fahad lashari

fahad lashari