Create a new function named max which accepts two numbers and I get msg 'max' function isn't returning a number.

Hi Dennis,

I think you were over thinking this one. You have the answer but you need to remove the

  var num1 = prompt("Please enter first number");
  var num2 = prompt("Please enter second number");

What's happening is num1 and num2 are being passed into the function but those two lines immediately overwrites the values of num1 and num2 with the prompt value which is not needed. All you need is

function max(num1, num2){
  if(num1 > num2){
    return num1
  }else{
    return num2
  }
}

Once you learn ternary operator you can do this in one line

function max(num1, num2){
  return num1 > num2 ? num1 : num2;
}

FYI as a side note, prompt returns a string. So best practice would be to parseInt() the returned value of prompt

var num1 = parseInt(prompt("Please enter first number"));
var num2 = parseInt(prompt("Please enter second number"));

Hey Dennis,

Your code is pretty much fine, except you are adding two lines that the challenge didn't ask for. If you delete the two var lines you added, you'll be good to go.

function max(num1,num2) {
  if (num1 > num2) {
    return num1;
  }
  else {
    return num2;
  }
}

Keep Coding!

Hello Dennis,

Quick solution here: the challenge does not required any input, just set up the function as you did but get rid of the inputs and the compiler will take care of the input to test your code.

Vitto

My solution ddidnt use an else.

max(a,b) {
if (a<b){
return b;
}
}