Create a new function named max() which accepts two numbers as arguments. The function should return the larger of the 2

I can see a couple issues in your code. The first is a syntax error.

foo = "bar";
if ( foo == "bar" ) 
{
  foo = "something";
}

is the general syntax for an If statement. You will need to add (first > second) for your condition test.

Second, a style issue. Why define the var first and the var second? Would it work to just test if (a > b) ?

Third, I see a minor logic issue. What about an edge case where a === 3 and b === 3? You'll get a result that the second is greater, maybe add an "else if" clause? (that might be beyond the scope of your challenge)

In addition to what Brian has said, you are missing a final closing curly brace (}) for your function, which will cause an error.

Like mentioned above you need a closing bracket for your function but the challenge also need you to return the largest of the two numbers not a string. You would need to return a or return b.

I found this was the solution that worked for me. Yes I was missing the extra bracket and returning a string. I may have been over thinking the question. Thanks for all your help guys. I really appreciate the support.

function max(num1, num2) { if (num1 > num2) { return num1; } else{ return num2; } }

function max(a,b) { 
   if (a > b) 
   { 
        return("first is greater"); 
    } 
    else 
    {
          return("second is greater"); 
    } 

max(4,5);

Still two issues. Look carefully at your brackets. You need a closing bracket for every opening bracket. Also, like Julian said, you should be returning the larger number.

Thanks guys, This is where I am now based on the comments. It's still not passing however.

Here is the question again so you don't have to scroll up: Create a new function named max() which accepts two numbers as arguments. The function should return the larger of the two numbers. You'll need to use a conditional statement to test the 2 numbers to see which is the larger of the two.

function max(a,b){ if (a > b) { return("first is greater"); } else { return("second is greater"); } max(4,5);