Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

Development Tools Creating a Project Pages Site

2 Answers

I'm not seeing a 404 at https://aakashsr.github.io/Treehouse-techdegree-project-1/. It is working correctly for me. Is this the URL you are attempting to visit?

Couple of tips to clean up your repository, though:

  • If you don't have a .gitignore file, create one and add any files or folders to it that you don't want tracked with version control. There is no reason to have a debug log in your repo, for example.
  • You are using CDNs for all of your images, so you do not need to include a folder of images in your repository.
  • Move the README to the root of your project. It doesn't belong in the css folder.
Aakash Srivastav
seal-mask
.a{fill-rule:evenodd;}techdegree
Aakash Srivastav
Full Stack JavaScript Techdegree Student 11,621 Points

Is is good to add your images from your local machine ? Is not there any security issue? I am having doubt about it and doesn't have any clear knowledge about it all. Please help.

You can do it either way. There is no security problem with it. I was just pointing out that you are not currently using them in your CSS, so there is no reason to include them in the repo.

If you wanted to instead serve the image files from your repository, you just need to update the background-image urls in your CSS.

For example:

.twitter{
    background-image:url("https://cdn4.iconfinder.com/data/icons/miu-flat-social/60/twitter-32.png");
}

Will change to:

.twitter {
    background-image: url("img/twitter.svg");
}
Aakash Srivastav
seal-mask
.a{fill-rule:evenodd;}techdegree
Aakash Srivastav
Full Stack JavaScript Techdegree Student 11,621 Points

Actually the problem was "firstly I uploded the icons by the second path i,e url("img/twitter.svg")" , but it didn't work so I upload the icons from the net.

The path should work. Your img folder is inside your css folder, so if you are referencing them with relative paths, you have to be careful.

I checked your git history. Previously, you were attempting this:

.twitter{
    background-image: url("twitter.svg");
}

This will fail because it is looking for that file inside the css folder.

And this:

 .twitter{
        background-image: url("../img/twitter.svg");
 }

This will fail because it is looking for the img folder from the root directory (which does not exist).

Try the path I proposed.