Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Object-Oriented JavaScript Getters and Setters Creating Setter Methods

Creating Setter Methods

Is this the correct way to Create Setter Methods?

creating_setters.js
class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }

    stringGPA() {
        return this.gpa.toString();
    }
  set major(student) {
    if (this.level === 'Senior' || this.level 'Junior') {
      this._major = major; 
    } else {
      this._major = none; 
    }
}
  get major() {
    return this._major;
  }

  var student = new Student(3.9, 61);
student.major = 'Computer Science';
console.log(student);



    get level() {
        if (this.credits > 90 ) {
            return 'Senior';
        } else if (this.credits > 60) {
            return 'Junior';
        } else if (this.credits > 30) {
            return 'Sophomore';
        } else {
            return 'Freshman';
        }
    }
}

var student = new Student(3.9, 60);

1 Answer

Steven Parker
Steven Parker
229,788 Points

Your basic setter structure is good, but you have several other issues:

  • the value major being assigned is not defined, the parameter name is student
  • the comparison operator is missing between this.level and 'Junior'
  • the alternative value to assign should be 'None' (a string)
  • the instructions don't ask for a getter to be created
  • the instructions don't ask for any code to be created outside of the class
  • there should also not be any extra lines of code added to the class that are not part of the setter