Critique my disemvowel

Question

Hi all,
This code worked, and i passed the test, but I think it could still be better as I didn't use .upper or .lower.
Keen for a mod, or someone more experienced to help me understand if my brain is working in the correct way to address this kind of problem:
python
def disemvowel(word):
    vowels = ["a", "e", "i", "o", "u", "A", "E", "I", "O", "U"]
    word_as_list = list(word)
    for vowel in vowels:
        for letters in word_as_list:
            try:
                word_as_list.remove(vowel)
            except ValueError:
                pass
    return ''.join(word_as_list)

Stuart Wright · Accepted Answer

You can run into problems when you try to loop over a list and remove items from it as you go. Although it seems to have worked in this case, it's generally bad practice. It would be safer to create a new output variable, something like:
python
def disemvowel(word):
    vowels = ["a", "e", "i", "o", "u", "A", "E", "I", "O", "U"]
    word_as_list = []
    for letter in word:
        if letter not in vowels:
            word_as_list.append(letter)
    return ''.join(word_as_list)

I wouldn't worry too much about using .upper() or .lower() for this challenge as it doesn't actually save any work (it's just as quick to type out the full list of vowels), but here is an example of how you could have worked it in:
python
def disemvowel(word):
    vowels = ["a", "e", "i", "o", "u"]
    word_as_list = []
    for letter in word:
        if letter.lower() not in vowels:
            word_as_list.append(letter)
    return ''.join(word_as_list)

Welcome to the Treehouse Community

Looking to learn something new?

Sebastiaan Stoffels

Sebastiaan Stoffels

Critique my disemvowel

1 Answer

Stuart Wright

Stuart Wright