Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

Android Build a Simple Android App (2014) Basic Android Programming Generating a Random Number

Eleni Minadaki
Eleni Minadaki
3,687 Points

Different result from lesson when click the Button

Hi!Whwn click the button instead see 0, 1,2 there is 9 digits (385580803 etc) here is my code,i can't find what's wrong

import java.util.Random;

public class FunFactsActivity extends Activity {

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_fun_facts);

        //Declare our view variables and assign the views from the layout file
        final TextView factLabel = (TextView) findViewById(R.id.factTextView);
        Button showFactButton =(Button) findViewById(R.id.showFactButton);
        View.OnClickListener listener = new View.OnClickListener() {
            @Override
            public void onClick(View view) {
                //The button was clicked,so update the fact label with a new fact
              String fact = "";
                //Randomly select a fact
                Random randomGenerator = new Random(); //Construct a new random generator
                int randomNumber = randomGenerator.nextInt();
                fact = randomNumber + "";

                //Update the label with our dynamic fact
                factLabel.setText(fact);
            }
        };
        showFactButton.setOnClickListener(listener);
    }

    @Override
    public boolean onCreateOptionsMenu(Menu menu) {
        // Inflate the menu; this adds items to the action bar if it is present.
        getMenuInflater().inflate(R.menu.menu_fun_facts, menu);
        return true;
    }

    @Override
    public boolean onOptionsItemSelected(MenuItem item) {
        // Handle action bar item clicks here. The action bar will
        // automatically handle clicks on the Home/Up button, so long
        // as you specify a parent activity in AndroidManifest.xml.
        int id = item.getItemId();

        //noinspection SimplifiableIfStatement
        if (id == R.id.action_settings) {
            return true;
        }

        return super.onOptionsItemSelected(item);
    }
}

Thanks for any help

2 Answers

This code will produce a random number and change the button label text to that number.

The nextInt() method does that for you. However, if you don't stipulate a number inside the method, the upper bound will be high - which may explain your result.

Try adding a 10 in there - nextInt(10) - that may bring your number under control.

Steve.

Eleni Minadaki
Eleni Minadaki
3,687 Points

Hi Steve,thanks a lot for your reply, it helps a lot!!