Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Django ORM Total Control Q

Y B
Y B
14,136 Points
Posted by Y B
Y B
14,136 Points

django orm Q challenge - not sure why not passing

I think my code looks ok, so not sure why I'm failing the challenge?

products/views.py 
import datetime

from django.db.models import Q
from django.shortcuts import render, get_object_or_404

from . import models


def good_reviews(request):
    reviews = models.Review.objects.filter(rating__gte=3)
    return render(request, 'products/reviews.html', {'reviews': reviews})


def recent_reviews(request):
    six_months_ago = datetime.datetime.today() - datetime.timedelta(days=180)
    reviews = models.Review.objects.exclude(created_at__lt=six_months_ago)
    return render(request, 'products/reviews.html', {'reviews': reviews})


def product_detail(request, pk):
    product = get_object_or_404(models.Product, pk=pk)
    four_weeks_ago = datetime.datetime.today() - datetime.timedelta(days=28)
    reviews = product.review_set.order_by('-created_at').filter(
        Q(rating__gte=8) | Q(created_at__lt=four_weeks_ago)
    )
    return render(request, 'products/product_detail.html', {'product': product, 'reviews': reviews})

4 Answers

jacinator
jacinator
11,936 Points

You're very close!

def product_detail(request, pk):
    product = get_object_or_404(models.Product, pk=pk)
    four_weeks_ago = datetime.datetime.today() - datetime.timedelta(days=28)
    reviews = product.review_set.order_by('-created_at').filter(
        # Q(rating__gte=8) | Q(created_at__lt=four_weeks_ago)
        Q(rating__gte=8) | Q(created_at__gte=four_weeks_ago),
    )
    return render(request, 'products/product_detail.html', {'product': product, 'reviews': reviews})
Martynas Zilinskas
Martynas Zilinskas
22,087 Points
Martynas Zilinskas
Martynas Zilinskas
22,087 Points

Can I ask why would you use greater than or equal but not less than with the date? : Q(rating_gte=8) | Q(created_at_gte=four_weeks_ago)

jacinator
jacinator
11,936 Points 
Q(rating_gte=8) | Q(created_at__gte=four_weeks_ago

Dates get greater with the passage of time. The older a date is, the less it is. Therefore, comparing things as a >= will return only dates that occur since the date that is provided.

Using less than the date would provide all dates in the past, without limiting the time span.

Y B
Y B
14,136 Points
Y B
Y B
14,136 Points

Thanks ---ah missed that!

Martynas Zilinskas
Martynas Zilinskas
22,087 Points
Martynas Zilinskas
Martynas Zilinskas
22,087 Points

Thanks, I got confused with the previous task with six months :) Many Thanks, great answer :)