Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Getting a Handle on the DOM Practice Selecting Elements

Posted by remi poolen
remi poolen
6,697 Points

do i need to edit the html file?

i need to select al the links (listitems) within the "nav" tag. But the listitems don't have a combined id, class or name attribute assigned. and there are more dan those 3 <li> tags, so it is not possible to getElementsBySomeElement.

If i add a name attribute in the html file name="navli" to the listitems and set: let navigationLinks = document.getElementsByName("navli); or navigationLinks = document.querySelectorAll('[name=navli]');

it says: was expecting 3 items instead of 0.

js/app.js 
let navigationLinks = document.getElementsByTagName('nav') ;
let galleryLinks;
let footerImages;
index.html 
<!DOCTYPE html>
<html>
  <head>
    <meta charset="utf-8">
    <title>Nick Pettit | Designer</title>
    <link rel="stylesheet" href="css/normalize.css">
    <link href='http://fonts.googleapis.com/css?family=Changa+One|Open+Sans:400italic,700italic,400,700,800' rel='stylesheet' type='text/css'>
    <link rel="stylesheet" href="css/main.css">
    <link rel="stylesheet" href="css/responsive.css">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
  </head>
  <body>
    <header>
      <a href="index.html" id="logo">
        <h1>Nick Pettit</h1>
        <h2>Designer</h2>
      </a>
      <nav>
        <ul>
          <li><a href="index.html" class="selected">Portfolio</a></li>
          <li><a href="about.html">About</a></li>
          <li><a href="contact.html">Contact</a></li>
        </ul>
      </nav>
    </header>
    <div id="wrapper">
      <section>
        <ul id="gallery">
          <li>
            <a href="img/numbers-01.jpg">
              <img src="img/numbers-01.jpg" alt="">
              <p>Experimentation with color and texture.</p>
            </a>
          </li>
          <li>
            <a href="img/numbers-02.jpg">
              <img src="img/numbers-02.jpg" alt="">
              <p>Playing with blending modes in Photoshop.</p>
            </a>
          </li>
        </ul>
      </section>
      <footer>
        <a href="http://twitter.com/nickrp"><img src="img/twitter-wrap.png" alt="Twitter Logo" class="social-icon"></a>
        <a href="http://facebook.com/nickpettit"><img src="img/facebook-wrap.png" alt="Facebook Logo" class="social-icon"></a>
        <p>&copy; 2016 Nick Pettit.</p>
      </footer>
    </div>
  <script src="js/app.js"></script>
  </body>
</html>
Dimitrius Ionov
Dimitrius Ionov
17,737 Points
Dimitrius Ionov
Dimitrius Ionov
17,737 Points

you can select by type of a tag like this document.querySelectorAll("nav li a");

1 Answer

Aakash Srivastav
seal-mask
.a{fill-rule:evenodd;}techdegree
Aakash Srivastav
Full Stack JavaScript Techdegree Student 11,638 Points
Aakash Srivastav
.a{fill-rule:evenodd;}techdegree
Aakash Srivastav
Full Stack JavaScript Techdegree Student 11,638 Points

Hey remi poolen , you can use document.querySelectorAll to select all the links withing nav element.
Here is the code: 

let navigationLinks = document.querySelectorAll('nav li a');

Similary for second question , you can type: 

let navigationLinks = document.querySelectorAll('nav li a');
let galleryLinks =  document.querySelectorAll('#gallery li a');
let footerImages ;

And for the third question: 

let navigationLinks = document.querySelectorAll('nav li a');
let galleryLinks =  document.querySelectorAll('#gallery li a');
let footerImages = document.querySelectorAll('footer img');

Hope it helps :)