Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

CSS

Doesn't work for me

Despite following instructions the nav does not float to the right, nor does the logo float to the left past breakpoints. Please advise. Snippet of code below:

 /**********************************
  HEADER
  ***********************************/

  nav {
    background: none;
    float: right;
    font-size: 1.125em;
    margin-right: 5%;
    text-align: right;
    width: 45%;
  }


  #logo {
    float: left;
    margin-left: 5%;
    text-align: left;
    width: 45%;
  }

   h1 {
    font-size: 2.5em;
  }    

   h2 {
    font-size: 0.825em;
    margin-bottom: 20px;
  }

   header {
    border-bottom: 5px solid #599a68;
    margin-bottom: 60px;
  }

  /**********************************
  TWO COLUMN LAYOUT
  ***********************************/

  #primary {
    width: 50%;
    float: left;
  }

  #secondary {
    width: 40%;
    float: right;
  }
Bogdan Cabaj
Bogdan Cabaj
16,335 Points

Please include HTML.

<!DOCTYPE html>
<html>
  <head>
    <meta charset="utf-8">
    <title>My page</title>
    <link rel="stylesheet" href="css/normalize.css">
    <link href="https://fonts.googleapis.com/css?family=Changa+One|Open+Sans" rel="stylesheet">
    <link rel="stylesheet" href="css/main.css">
        <link rel="stylesheet" href="css/responsive.css">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
  </head>
<body>
  <header>
    <a href="index.html" id="logo">
      <h1>Test</h1>
      <h2>Test 2</h2>
    </a>
    <nav>
      <ul>
        <li><a href="index.html" class="selected">Home</a></li>
        <li><a href="insights.html">Insights</a></li>
        <li><a href="contactus.html">Contact us</a></li>
      </ul>
    </nav>
  </header>
  <div id="wrapper">
    <section>
      <ul id="gallery">
        <li>
           <a href="img/numbers-01.jpg">
              <img src="img/numbers-01.jpg" alt="">
           <p>Text here</p>
           </a>
        </li>
        <li>
           <a href="img/numbers-02.jpg">
              <img src="img/numbers-02.jpg" alt="">
           <p>Text here</p>
           </a>
        </li>
        <li>
           <a href="img/numbers-06.jpg">
              <img src="img/numbers-06.jpg" alt="">
           <p>Text here</p>
           </a>
        </li>
        <li>
           <a href="img/numbers-09.jpg">
              <img src="img/numbers-09.jpg" alt="">
           <p>Text here</p>
           </a>
        </li>
        <li>
           <a href="img/numbers-12.jpg">
              <img src="img/numbers-12.jpg" alt="">
           <p>Text here</p>
           </a>
        </li>

      </ul>
    </section>

      <footer>
        <a href="http://twitter.com/"><img src="img/twitter-wrap.png" alt="Twitter logo" class="social-icon"></a>
        <a href="http://facebook.com/"><img src="img/facebook-wrap.png" alt="Facebook logo" class="social-icon"></a>
        <p>&copy; 2017</p>
      </footer>
    </div>
   </body>
</html>

2 Answers

Dave McFarland
STAFF
Dave McFarland
Treehouse Teacher

Hello jkr

In your responsive.css file, you have an extra } character for the #galler li selector:

#gallery li {
    width: 28.3333%}
}

you should have a semicolon after the width declaration like this:

#gallery li {
    width: 28.3333%;
}

A great resource for finding errors like these is the CSS Validator.

Bogdan Cabaj
Bogdan Cabaj
16,335 Points

This is somehow confusing since it looks like some selectors are missing from css (#primary, #secondary). Please include a link to your workspace for this problem and I'll see what I can do. Unless other people are willing to pitch in.

Sorry I only showed a snippet of my responsive.css, here is the full css:

@media screen and (min-width: 480px) {


  /**********************************
  TWO COLUMN LAYOUT
  ***********************************/

  #primary {
    width: 50%;
    float: left;
  }

  #secondary {
    width: 40%;
    float: right;
  }



  /**********************************
  3 * 5 = 15
  100 - 15 = 85%
  85/3 = 28.333333333
  ***********************************/

  /**********************************
  PAGE: PORTFOLIO
  ***********************************/

  #gallery li {
    width: 28.3333%}
}

  #gallery li:nth-child(4n) {
    clear: left;
}



  /**********************************
  PAGE: ABOUT
  ***********************************/

  .profile-photo {
    float: left;
    margin: 0 5% 80px 0;
  }

}

@media screen and (min-width: 660px) {

  /**********************************
  HEADER
  ***********************************/

  nav {
    background: none;
    float: right;
    font-size: 1.125em;
    margin-right: 5%;
    text-align: right;
    width: 45%;
  }


  #logo {
    float: left;
    margin-left: 5%;
    text-align: left;
    width: 45%;
  }

   h1 {
    font-size: 2.5em;
  }    

   h2 {
    font-size: 0.825em;
    margin-bottom: 20px;
  }

   header {
    border-bottom: 5px solid #599a68;
    margin-bottom: 60px;
  } 
}

And my main css:

/**********************************
GENERAL
***********************************/

body {
  font-family: 'Open Sans', sans-serif;
}

#wrapper {
  max-width: 940px;
  margin: 0 auto;
  padding: 0 5%;
}

a {
  text-decoration: none;
}

img {
  max-width: 100%;
}

/**********************************
HEADING
***********************************/

header {
  margin: 0 0 30px 0;
  padding: 5px 0 0 0;
  width: 100%;
}

#logo {
  text-align: center;
  margin: 0;
}

h1 {
  font-family: 'Open Sans', sans-serif;
  margin: 15px 0;
  font-size: 1.75em;
  font-weight: normal;
  line-height: 0.8em;
}

h2 {
  font-size: 1em;
  margin: -5px 0 0;
  font-weight: normal;
}

/**********************************
NAVIGATION
***********************************/

nav {
  text-align: center;
  padding: 10px 0;
  margin: 20px 0 0;
}

nav ul {
  list-style: none;
  margin: 0 10px;
  padding: 0;
}

nav li {
  display: inline-block;
}

nav a {
  font-weight: 800;
  padding: 15px 10px;
}

/**********************************
FOOTER
***********************************/

footer {
  font-size: 0.75em;
  text-align: center;
  clear: both;
  padding-top: 50px;
  color: #ccc;
}

.social-icon {
  width: 20px;
  height: 20px;
  margin: 0 5px;
}

/**********************************
PAGE: PORTFOLIO
***********************************/

#gallery {
  margin: 0;
  padding: 0;
  list-style: none;
}

#gallery li {
  float: left;
  width: 45%;
  margin: 2.5%;
  background-color: #f5f5f5;
  color: #bdc3c7;
}

#gallery li a p {
  margin: 0;
  padding: 5%;
  font-size: 0.75em;
  color: #bdc3c7;
}

/**********************************
PAGE: ABOUT
***********************************/

.profile-photo {
  display: block;
  max-width: 150px;
  margin: 0 auto 30px;
  border-radius: 100%;
}

/**********************************
PAGE: CONTACT
***********************************/

.contact-info {
    list-style: none;
    padding: 0;
    margin: 0;
    font-size: 0.9em;
}

.contact-info a {
    display: block;
    min-height: 20px;
    background-repeat: no-repeat;
    background-size: 20px 20px;
    padding: 0 0 0 30px;
    margin: 0 0 10px;
}

.contact-info li.phone a {
    background-image: url('../img/phone.png');
}

.contact-info li.mail a {
    background-image: url('../img/mail.png');
}

.contact-info li.twitter a {
    background-image: url('../img/twitter.png');
}

/**********************************
COLOURS
***********************************/

/* site body */
body {
  background-color: #fff;
  color: #999;
}  

/* blue header */
header {
  background: #002266;
  border-color: #002266;
}

/* nav background on mobile */
nav {
  background: #003399;
}

/* logo text */
h1, h2 {
  color: #fff;
}

/* links */
a {
  color: #6ab47b;
}

/* nav link */
nav a, nav a:visited {
  color: #fff;
}

/* selected nav link */
nav a.selected, nav a:hover {
  color: #a6a6a6;
}