Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

Python Python Basics (2015) Shopping List App Refactor

dono,where i am wrong?

the question is to refactor the code

shopping_list.py
def show_help():
    # print out instructions on how to use the app
    print("What should we pick up at the store?")
    print("""
Enter 'DONE' to stop adding items.
Enter 'HELP' for this help.
Enter 'SHOW' to see your current list.
""")

def show_list(shopping_list):
    # print out the list
    print("Here's your list:")

    for item in shopping_list:
        print(item)

def add_to_list(shopping_list, new_item):
    # add new items to our list
     while True:
        # ask for new items
        new_item = input("> ")

        # be able to quit the app
        if new_item == 'DONE':
            break
        elif new_item == 'HELP':
            show_help()
            continue
        elif new_item == 'SHOW':
            show_list(shopping_list)
            continue
        shopping_list.append(new_item)
    print("Added {}. List now has {} items.".format(new_item, len(shopping_list)))
    return shopping_list
def main():
    show_help()
    # make a list to hold onto our items
    shopping_list = []
    add_to_list(shopping_list, new_item)

    show_list(shopping_list)
main()    

1 Answer

Hi there,

It looks like you've moved some of the code into another function - I think that's going to throw it off. This challenge also checks to make sure all of the code is inside main(), so you shouldn't call it at the bottom (in a real program you would need to call it, but the challenge doesn't like it - it does that for you in the background when it checks your work). With challenges like this, you want to be careful to only do what it asks, and not more - the checks it performs will often fail if you do too much, or not exactly what it asks. In this case, you just need to add your "def main():" line above line 22, then indent everything beneath it by one tab. This can be done easily by selecting all of it and hitting Ctrl (or Cmd on Mac) + ] (closing square bracket).