Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Traversing the DOM Solution: Using nextElementSibling

Yosif Qassim
Yosif Qassim
6,367 Points
Posted by Yosif Qassim
Yosif Qassim
6,367 Points

down button is not working

why the button is not working ????? 

const input = document.querySelector('input');
const p = document.querySelector('p.d');
const button = document.getElementsByClassName('down');
const listUl = listDiv.querySelector('ul');



listUl.addEventListener('click', (event) => {

  if (event.target.className == 'down') {
    let li = event.target.parentNode;
  let nextLi = li.nextElementSibling;
    let ul = li.parentNode;
    if (nextLi) {
    ul.insertBefore( nextLi , li);
    }
  }                        
});

<!DOCTYPE html>
<html>
  <head>
    <title>JavaScript and the DOM</title>
    <link rel="stylesheet" href="css/style.css">
  </head>
  <body>
    <h1 id="myHeading">JavaScript and the DOM</h1>
    <p>Making a web page interactive</p>    
  <p class="d">Things that are purple:</p>

    <ul>
      <li>grapes 
        <button class="down">Down</button>
      </li>
      <li>amethyst
      <button class="down">Down</button>
      </li>
      <li>lavender
      <button class="down"> Down</button>
      </li>
      <li>plums
  <button class="down">Down</button>
      </li>
    </ul>
    <script src="app.js"></script>
  </body>
</html>

1 Answer

Robert Anthony
Robert Anthony
19,952 Points

In your code you have this line:

const listUl = listDiv.querySelector('ul');

But you don't set listDiv to a value or element before this line. This means that ListUI is undefined and when you set an event listener to it, nothing will happen.