Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript jQuery Basics (2014) Creating a Simple Drawing Application Perform: Part 5

Drawing application not working for me. Hoping another set of eyes can help catch what I'm missing.

I can't get any of the feature's from the drawing canvas to work. I've reviewed the exercise a second time and corrected one error that I noticed but it still doesn't work.

  1. Can't select any of the default red, blue or yellow buttons.

  2. Can't draw on the canvas.

  3. The color selector doesn't work. The "New Color" button won't toggle to reveal the RGB sliders.

  4. Which means I can't use the "Add Color" feature.

Here is my app.js code.


//Problem: No user interaction causes no change to application //Solution: When user interacts cause changes appropriately var color = $(".selected").css("background-color"); var $canvas = $("canvas"); var context = $canvas[0].getContext("2d"); var lastEvent; var mouseDown = false;

//When clicking on control list items $(".controls").on ("click", "li", (function(){ //Deselect sibling elements $(this).siblings().removeClass("selected"); //Select clicked elements $(this).addClass("selected"); //cache current color color = $(this).css("background-color"); });

//When "New Color" is pressed $("revealColorSelect").click(function(){ //Show color select or hide the color select changeColor(); $("#colorSelect").toggle(); });

//Update the new color span function changeColor(){ var r = $("#red").val(); var g = $("#green").val(); var b = $("#blue").val(); $("#newColor").css("background-color", "rgb(" + r + ", " + g + ", " + b + ")"); }

//When color sliders change $("input[type=range]").change(changeColor);

//When "Add Color" is pressed $("#addNewColor").click(function(){ //Append the color to the controls ul var $newColor = $("<li></li>"); $newColor.css("background-color", $("#newColor").css("background-color")); $(".controls ul").append($newColor); //Select the new color $newColor.click(); });

//On mouse events on the canvas $canvas.mousedown(function(e){ lastEvent = e; mouseDown = true; }).mousemove(function(e){ //Draw lines if(mouseDown) { context.beginPath(); context.moveTo(lastEvent.offsetX, lastEvent.offsetY); context.lineTo(e.offsetX, e.offsetY); context.strokeStyle = color; context.stroke(); lastEvent = e; } }).mouseup(function(){ mouseDown = false; }).mouseleave(function(){ $canvas.mouseup(); });

There is an error in your event delegation syntax. There is an extra parenthesis before your callback function.

// When clicking on control list items
$('.controls').on('click', 'li', (function() {
  // Deselect sibling elements
  $(this).siblings().removeClass('selected');
  // Select clicked elements
  $(this).addClass('selected');
  // cache current color
  color = $(this).css('background-color');
});

should be

// When clicking on control list items
$('.controls').on('click', 'li', function() {
  // Deselect sibling elements
  $(this).siblings().removeClass('selected');
  // Select clicked elements
  $(this).addClass('selected');
  // cache current color
  color = $(this).css('background-color');
});

Without seeing the code executing elsewhere its hard to track down anything other than syntax errors. Perhaps drop your code in JSFiddle or CodePen for us to review?

3 Answers

Thanks Andrew. That got the canvas operating correctly.

Still can't activate the "New Color" button.

I'll log into CodePen next.

By the way, how do I post a question on CodePen? I'm a recently new user.

Hummm. Succesfully and oddly enough, it works just fine when I open it in the Brackets text editor with no further edits. Not sure why it doesn't want to operate with the Treehouse Workspaces preview button but oh well. I'm satisfied.

Great!