Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Basic Object-Oriented Python Creating a Memory Game Final Product

Posted by JASON LEE
JASON LEE
17,351 Points

Dungeon game challenge - would anyone like to review?

I made the dungeon game. Anyone can play it, but more importantly if anyone wants to review the code, feedback is much appreciated. I'm self-learning and never had someone look at my code, so I have no idea whether it is being done right (best practice, clean code, etc) other than the bugs and testing that it works...

https://github.com/jlee474/Python_dungeon.git

1 Answer

Brian Chalfant
Brian Chalfant
8,720 Points

Hi Jason,

I think your program looks great. The code looked clean to me. The only critique I have for you is that in order to add columns to the game, I had to manually type in the Column Identifiers 'F', 'G', 'H' etc. So maybe it would be easier to have a global constant for both rows and columns and make them an integer value and then populate the column identifiers as a list comprehension.

Really fantastic work.

-Brian

JASON LEE
JASON LEE
17,351 Points

Agreed 100%. I was thinking the exact same thing with the column identifiers. Thanks for your feedback Brian.