Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

PHP Object-Oriented PHP Basics (Retired) Properties and Methods Mid-Course Challenge

Error on using $this->flavor - what is wrong with this code? Thank you.

<?php

class Fish { public $common_name; public $flavor; public $record_weight;

function __construct($name,$flavor,$record){
    $this->common_name = $name;
    $this->flavor = $flavor;
    $this->record_weight = $record;
}
function getInfo(){
    return "A" . $this->common_name;
    return "is an" . $this->flavor;
    return "flavored fish .";
    return "The world record weight is " . $this->record_weight;

}

} $bass = new Fish("Largemouth Bass", "Excellent", "22 pounds 5 ounces"); ?>

fish.php
<?php 

class Fish {
    public $common_name;
    public $flavor;
    public $record_weight;

    function __construct($name,$flavor,$record){
        $this->common_name = $name;
        $this->flavor = $flavor;
        $this->record_weight = $record;
    }
    function getInfo(){
        return "A" . $this->common_name;
        return "is an" . $this->flavor;
        return "flavored fish .";
        return "The world record weight is " . $this->record_weight;

    }
}
$bass = new Fish("Largemouth Bass", "Excellent", "22 pounds 5 ounces");
?>

2 Answers

Ahmed Abbouh
Ahmed Abbouh
17,034 Points

hi, and welcome. your getInfo() function keep returning the first string "A" . $this->common_name;

first try to echo out your function using your newly created instance $bass

<?php
echo $bass->getInfo();
?>

and you can change the return value of your function to something simpler:

<?php
function getInfo(){
        return "A " . $this->common_name . " is an " . $this->flavor . " flavored fish . The world record weight is "
 . $this->record_weight;

    }
?>

Your final code:

<?php

class Fish {
    public $common_name;
    public $flavor;
    public $record_weight;

    function __construct($name,$flavor,$record){
        $this->common_name = $name;
        $this->flavor = $flavor;
        $this->record_weight = $record;
    }
    function getInfo(){
        return "A " . $this->common_name . " is an " . $this->flavor . " flavored fish . The world record weight is " . $this->record_weight;

    }
}

$bass = new Fish("Largemouth Bass", "Excellent", "22 pounds 5 ounces");

//access getInfo inside $bass
echo $bass->getInfo();

?>

final result: A Largemouth Bass is an Excellent flavored fish . The world record weight is 22 pounds 5 ounces

i hope this solves your problem. Good coding!

Thank you Ahmed! All good now. :-)