Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

PHP Object-Oriented PHP Basics (Retired) Properties and Methods Mid-Course Challenge

Posted by lorinacapistrano
lorinacapistrano
3,371 Points

Error on using $this->flavor - what is wrong with this code? Thank you.

<?php

class Fish { public $common_name; public $flavor; public $record_weight;

function __construct($name,$flavor,$record){
    $this->common_name = $name;
    $this->flavor = $flavor;
    $this->record_weight = $record;
}
function getInfo(){
    return "A" . $this->common_name;
    return "is an" . $this->flavor;
    return "flavored fish .";
    return "The world record weight is " . $this->record_weight;

}

} $bass = new Fish("Largemouth Bass", "Excellent", "22 pounds 5 ounces"); ?>

fish.php 
<?php 

class Fish {
    public $common_name;
    public $flavor;
    public $record_weight;

    function __construct($name,$flavor,$record){
        $this->common_name = $name;
        $this->flavor = $flavor;
        $this->record_weight = $record;
    }
    function getInfo(){
        return "A" . $this->common_name;
        return "is an" . $this->flavor;
        return "flavored fish .";
        return "The world record weight is " . $this->record_weight;

    }
}
$bass = new Fish("Largemouth Bass", "Excellent", "22 pounds 5 ounces");
?>

2 Answers

Ahmed Abbouh
Ahmed Abbouh
17,034 Points
Ahmed Abbouh
Ahmed Abbouh
17,034 Points

hi, and welcome. your getInfo() function keep returning the first string "A" . $this->common_name;

first try to echo out your function using your newly created instance $bass

<?php
echo $bass->getInfo();
?>

and you can change the return value of your function to something simpler:

<?php
function getInfo(){
        return "A " . $this->common_name . " is an " . $this->flavor . " flavored fish . The world record weight is "
 . $this->record_weight;

    }
?>

Your final code:

<?php

class Fish {
    public $common_name;
    public $flavor;
    public $record_weight;

    function __construct($name,$flavor,$record){
        $this->common_name = $name;
        $this->flavor = $flavor;
        $this->record_weight = $record;
    }
    function getInfo(){
        return "A " . $this->common_name . " is an " . $this->flavor . " flavored fish . The world record weight is " . $this->record_weight;

    }
}

$bass = new Fish("Largemouth Bass", "Excellent", "22 pounds 5 ounces");

//access getInfo inside $bass
echo $bass->getInfo();

?>

final result: A Largemouth Bass is an Excellent flavored fish . The world record weight is 22 pounds 5 ounces

i hope this solves your problem. Good coding!

lorinacapistrano
lorinacapistrano
3,371 Points
lorinacapistrano
lorinacapistrano
3,371 Points

Thank you Ahmed! All good now. :-)