Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

JavaScript JavaScript and the DOM (Retiring) Traversing the DOM Sibling Traversal

Nick Retel
PLUS
Nick Retel
Courses Plus Student 4,516 Points

e.target.previousSibling.className += " highlight"; affects all buttons / p elements why is this not correct?

Why is this code not correct according to Teamtreehouse? It works as expected:

e.target.previousSibling.className += " highlight";

app.js
const list = document.getElementsByTagName('ul')[0];

list.addEventListener('click', function(e) {
  if (e.target.tagName == 'BUTTON') {
    e.target.previousSibling.className += " highlight";
  }
});
index.html
<!DOCTYPE html>
<html>
    <head>
        <title>JavaScript and the DOM</title>
    </head>
    <link rel="stylesheet" href="style.css" />
    <body>
        <section>
            <h1>Making a Webpage Interactive</h1>
            <p>Things to Learn</p>
            <ul>
                <li><p>Element Selection</p><button>Highlight</button></li>
                <li><p>Events</p><button>Highlight</button></li>
                <li><p>Event Listening</p><button>Highlight</button></li>
                <li><p>DOM Traversal</p><button>Highlight</button></li>
            </ul>
        </section>
        <script src="app.js"></script>
    </body>
</html>

2 Answers

Hi Nick,

The tester doesn't want the space you have before highlight.

I think your intention was to add the class to what is already there, making sure there's a space.

You should assume that the class should be set to "highlight" only.

Nick Retel
PLUS
Nick Retel
Courses Plus Student 4,516 Points

Yeah you are correct. "Add a highlight class" made me think I had to add an additional class. Got it sorted now.