Feedback on my solution? Very different from the video!

Question

def game():
  import random 
  compGuess = random.randint(1,11)
  numberOfGuesses = 0;
  MAX_GUESSES = 5

  def losingMessage():
    print("Sorry, you have run out of guesses! My number was: {}\n".format(compGuess))
    print("Play again? (y/n)")
    userChoice = input(">>> ")
    if userChoice.lower() == "y":
      game()
    else:
      print("Better luck next time!")
      exit()


  def winningMessage():
    print("Congratulations! You were correct, {} was my number. It took you {} guesses".format(compGuess, numberOfGuesses))
    print("Play again? (y/n)")
    userChoice = input(">>> ")
    if userChoice.lower() == "y":
      game()
    else:
      print("See you next time!")
      exit()


  while True:
    userGuess = input("Enter a number between 1 and 10 >>> ")
    if (int(userGuess) == compGuess):
      winningMessage()
    print("Sorry, that isn't my number. Try again!")
    numberOfGuesses += 1
    print("You have used {} out of {} guesses".format(numberOfGuesses, MAX_GUESSES))
    if (numberOfGuesses == MAX_GUESSES) :
      losingMessage()

game()

It works perfectly, except I wouldn't mind adding in a way of ensuring the input is between 1-10. I think there was probably a better solution of looping the script (when the user wants to play again) without putting it all in a function (game()). Also, maybe I could have used "break"? But I'm pretty bad when it comes to thinking about while loops etc.

Also... is random.randint(1,11) correct for getting a range of 1-10?

Answer 1 · 2015-01-30T03:11:52Z

January 30, 2015 3:11am

First: Imports should be outside of any functions.

Second: Functions should not usually be nested in other functions. Maybe make a class?

Third: Since winning or losing could be represented as booleans maybe you could incorperate that into your while loop? Example:

``python while hasNotLost and hasNotWon: #do thing

You have done a great job and seem to know a lot of python! I would recommend focusing on how and why things work for a little bit then restructure this to learn more. Maintain a program is almost as important as building it. Keep up the good work!

Goodluck!
--Ricky

Answer 2 · 2015-01-31T18:33:44Z

January 31, 2015 6:33pm

randint(1, 11) will give you a number between 1 and 11, inclusive (so 11 can be given).

If you want to check that their guess is between 1 and 10, do it :) if not int(guess) in range(1, 11):

Welcome to the Treehouse Community

Looking to learn something new?

Steven Wheeler

Steven Wheeler

Feedback on my solution? Very different from the video!

2 Answers

Ricky Catron

Ricky Catron

Kenneth Love

Kenneth Love