FeedBack on the code for the challenge.

Question

What do you think about my answer? Anything I can change or improve?

/*
This program takes user inputs
and evaluates them against the correct answers
*/


// Collects users answers
const question1 = prompt(`Name a programming language that's also a gem`); // Ruby
const question2 = prompt('What is another word for lexicon?'); // Dictionary
const question3 = prompt('Name the seventh planet from the sun'); // Uranus
const question4 = prompt('Name the worlds largest ocean'); // Pacific
const question5 = prompt('What kind of weapon is a falchion?'); // Sword
let correctAnswers = 0;

// Check if the questions answer is correct
if ( question1.toUpperCase() === 'RUBY' ) {
    correctAnswers += 1;
}

if (question2.toUpperCase() === 'DICTIONARY' ) {
    correctAnswers += 1;
}

if ( question3.toUpperCase() === 'URANUS' ) {
    correctAnswers += 1;
}

if (question4.toUpperCase() === 'PACIFIC' ) {
    correctAnswers += 1;
}

if (question5.toUpperCase() === 'SWORD' ) {
    correctAnswers += 1;
}

// prints out how many questions were answered right

if ( 5 === correctAnswers ) {
   document.write(`<p>You answered 5 out 5 right!<p>`);
} else {
  document.write(`<p>Sorry. You answered ${correctAnswers} out 5 right!.<p>`);
}

if (correctAnswers  === 5 ) {
    document.write(`<p><strong>You earned a gold crown!</strong></p>`);
} else if ( correctAnswers  >= 3 ) {
    document.write(`<p><strong>You earned a silver crown!</strong></p>`);
} else if ( correctAnswers  >= 1 ) {
    document.write(`<p><strong>You earned a bronze crown!</strong></p>`);
} else {
    document.write(`<p><strong>No crown for you.</strong></p>`);

Answer 1 · 2018-03-31T12:44:05Z

March 31, 2018 12:44pm

Had to see what you've learned so far... but with what you've done I'd say it's pretty good. You could consider calling the .toUpperCase() method directly on the question like so:

const question4 = prompt('Name the worlds largest ocean').toUpperCase()

That would make the if-statements a bit easier to read. Also, I'd change if ( 5 === correctAnswers ) to if ( correctAnswers === 5 ), like you did a few lines down. It reads like you would say it out loud normally.

Once you get a bit further in the course, you'll probably figure it's easier to store stuff in arrays or objects, then you just have something loop over it. Good luck :)

Answer 2 · 2018-03-31T18:07:47Z

March 31, 2018 6:07pm

Hey you have done a good job . I have some suggestions which i think make the program more realistic: 1.

if ( correctAnswers ===  5) {
   document.write(`<p>You answered 5 out 5 right!<p>`);
}

will look more readable. 2.Instead of just storing the value in "correctAnswers" , you can write something like this:

if( response5.toUpperCase() === "MURALIDHARAN"){
    correct_response += 1;
    alert("Yep....Thats right!!  " + "[ " +correct_response + " ]");
}

This will provide a glimpse of correct answers as you answer corrctly. Happy Coding :)

Welcome to the Treehouse Community

Looking to learn something new?

serhiipanchyshyn

serhiipanchyshyn

FeedBack on the code for the challenge.

2 Answers

Robert Schaap

Robert Schaap

Aakash Srivastav

Aakash Srivastav