Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript Basics (Retired) Making Decisions with Conditional Statements The Conditional Challenge

Emre K.
seal-mask
.a{fill-rule:evenodd;}techdegree seal-36
Emre K.
Full Stack JavaScript Techdegree Graduate 16,406 Points
Posted by Emre K.
.a{fill-rule:evenodd;}techdegree seal-36
Emre K.
Full Stack JavaScript Techdegree Graduate 16,406 Points

Feedback Request: The Conditional Challenge Project

I would greatly appreciate your feedback!

The project's snapshot link is at: https://w.trhou.se/rabflv2dt8

Note: I only used what was covered and taught up until now. Features like loops and functions have not been covered in the course yet.

Thanks.

1 Answer

Liam Clarke
Liam Clarke
19,938 Points

Hello

As you mentioned, you have not learnt a lot of the concepts that will allow me to provide a proper feedback review, but going off the scope of what you have learnt so far, this looks really good.

I'll note down a few things that are good and a few work on points that give room to improve:

Good

  1. Easy to read - your code is readable, with comments in a logical order
  2. Consistent - your code is consistant in the style, which makes it a lot easier to be maintained
  3. Assignment - All variables are referenced before they are used which is a good practice.

Improvements

  1. Radix - It is considered good practice to provide the radix parameter with parseInt. Without going into too much detail, this is to protect against incorrectly parsing, if a value is hexadecimal or octal by accident. MDN docs explain this very well
  2. Spacing - Make sure your spacing is consistent, this does not effect your code but it does effect the readability. Some places you have multiple spaces, some places you have no space between variable and some places you have 1 space.

As you can see, the Improvements are very small things with most of the code being at a very good standard for what you have learnt so far.

Make sure you come back to this and keep improving it as you learn new concepts.

Enjoy!

Emre K.
seal-mask
.a{fill-rule:evenodd;}techdegree seal-36
Emre K.
Full Stack JavaScript Techdegree Graduate 16,406 Points
Emre K.
.a{fill-rule:evenodd;}techdegree seal-36
Emre K.
Full Stack JavaScript Techdegree Graduate 16,406 Points

Hello Liam,

First of all, I want to thank you so much for taking your time, reviewing the project, and providing me with your valuable feedback!

I especially enjoyed this constructive feedback, as it touched on both the positive sides of the project and improvements possible.

I appreciate your kind words on easiness to read, consistency, and assignment structure. I had no idea about Radix until you pointed. I will surely head to MDN to discover more about this and implement it in the project. As for spacing, you are right; I did not notice the inconsistency until now. Perhaps I should make use of a code editor to spot the spacing differences in the future.

Now, I know how to make the project better.

Thank you for your time and the helpful feedback, Liam!