JavaScript DOM Scripting By Example Editing and Filtering Names Filter Invitees Who Have Not Responded

Torian Patterson
Torian Patterson
20,117 Points

Filter not working.

list elements without the id of responded still being displayed.

const form = document.getElementById('registrar');
const input = form.querySelector('input');

const mainDiv = document.querySelector('.main');
const ul = document.getElementById('invitedList');

const div = document.createElement('div');
const filterLabel = document.createElement('label');
const filterCheckBox = document.createElement('input');

filterLabel.textContent = "Hide those that haven't responded";
filterCheckBox.type = 'checkbox';
div.appendChild(filterLabel);
div.appendChild(filterCheckBox);
mainDiv.insertBefore(div, ul);

filterCheckBox.addEventListener('change', (e) => {
  const isChecked = e.target.checked;
  const lis = ul.children;
  if(isChecked) {
    for(let i = 0; i < lis.length; i += 1) {
      let li = lis[i];
      if(li.className === 'responded') {
        li.syle.display = '';
      }else {
        li.style.display = 'none';
      }
    }  
  }else{
    for(let i = 0; i < lis.length; i += 1) {
      let li = lis[i];
      li.style.display = '';
    } 
  }
});


function createLI(text) {
  const li = document.createElement('li');
  const span = document.createElement('span');
  span.textContent = text;
  li.appendChild(span);
  const label = document.createElement('label');
  label.textContent = 'Confirmed';
  const checkbox = document.createElement('input');
  checkbox.type = 'checkbox';
  label.appendChild(checkbox);
  li.appendChild(label);

  const editButton = document.createElement('button');
  editButton.textContent = 'edit';
  li.appendChild(editButton);

  const removeButton = document.createElement('button');
  removeButton.textContent = 'remove';
  li.appendChild(removeButton);
  return li;
}

form.addEventListener('submit', (e) => {
  e.preventDefault();
  const text = input.value;
  input.value = '';
  const li = createLI(text);
  ul.appendChild(li);
});

ul.addEventListener('change', (e) => {
  const checkbox = event.target;
  const checked = checkbox.checked;
  const listItem = checkbox.parentNode.parentNode;

  if (checked) {
   listItem.className = 'responded'; 
  } else{
    listItem.className = '';
  }
});

ul.addEventListener('click', (e) => {
 if (e.target.tagName === 'BUTTON') {
  const button = e.target;
  const li = e.target.parentNode;
  const ul = li.parentNode;
  if (button.textContent === 'remove') {
    ul.removeChild(li);
  } else if (button.textContent === 'edit') {
    const span = li.firstElementChild;
    const input = document.createElement('input');
    input.type = 'text';
    input.value = span.textContent;
    li.insertBefore(input, span);
    li.removeChild(span);
    button.textContent = 'save';
  }  else if (button.textContent === 'save') {
    const input = li.firstElementChild;
    const span = document.createElement('span');
    span.textContent = input.value;
    li.insertBefore(span, input);
    li.removeChild(input);
    button.textContent = 'edit';

  }
 } 
});

2 Answers

Osaro Igbinovia
Osaro Igbinovia
Full Stack JavaScript Techdegree Student 15,922 Points

Hi Torian, your code is good just a little syntax error in your conditional statement inside the 'for' loop of your 'filterCheckBox' event listener.

 if(li.className === 'responded') {
        li.syle.display = ''; //you mispelled the word 'style'
      }else {
        li.style.display = 'none';
      }

All you need do is spell it out correctly.

  if(li.className === 'responded') {
        li.style.display = '';
      }else {
        li.style.display = 'none';
      }
Teacher Russell
Teacher Russell
16,868 Points

Did you have a problem with the the header image breaking up, after you use the filter checkbox? I finally cut and pasted the code from the project files, and it still happens, so it's either Treehouses editor, or something in the CSS maybe not being supported? Maybe flexbox?