Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python

Posted by Matthew Earlywine
Matthew Earlywine
3,508 Points

Final Task of OOP Hands.py

I got stuck on this task and after a while I checked online to see what others had done. Well I saw several that stated to pass task 3, so I added thought this would be the answer but I get an error code saying "didn't get a new roll

hands.py 
from dice import D6


class Hand(list):
    def __init__(self, size=0, die_class=None, *args, **kwargs):
        if not die_class:
            raise ValueError("You must provide a die class")
        super().__init__()

        for _ in range(size):
            self.append(die_class())
        self.sort()

    def _by_value(self, value):
        dice = []
        for die in self:
            if die == value:
                dice.append(die)
        return dice


class CapitalismHand(Hand):
    def __init__(self, *args, **kwargs):
        super().__init__(size=2, die_class=D6, *args, **kwargs)

    @property
    def doubles(self):
        if self[0] == self[1]:
            return True

    @classmethod
    def reroll(cls):
        return cls

    @property
    def ones(self):
        return self._by_value(1)

    @property
    def twos(self):
        return self._by_value(2)

    @property
    def threes(self):
        return self._by_value(3)

    @property
    def fours(self):
        return self._by_value(4)

    @property
    def fives(self):
        return self._by_value(5)

    @property
    def sixes(self):
        return self._by_value(6)

    @property
    def _sets(self):
        return {
            1: len(self.ones),
            2: len(self.twos),
            3: len(self.threes),
            4: len(self.fours),
            5: len(self.fives),
            6: len(self.sixes)
        }

1 Answer

Steven Parker
Steven Parker
229,771 Points
Steven Parker
Steven Parker
229,771 Points

For the "double" method, the instructions said, "It should return True if both of the dice have the same value. Otherwise, return False.". It looks like you have the first case covered, but you still need to return False otherwise.

Then for the "reroll" method, remember that you have to put parentheses after the class name to create a new instance.

Matthew Earlywine
Matthew Earlywine
3,508 Points

Thanks Steven! I didn't put the False and still passed. Why would that be?

Steven Parker
Steven Parker
229,771 Points
Steven Parker
Steven Parker
229,771 Points

Perhaps the validator isn't testing both cases. You might want to alert the Support folks about it as a possible bug.