Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

General Discussion

Finally finished up my portfolio and wanted to get some opinions/reviews from fellow web developers

All critiques, suggestions and comments, negative or positive are welcome. I just want to know what others think of my work so far. If you'd like to share yours as well that would be cool too. My website url is http://www.ericandrewluna.com

4 Answers

Henrik Christensen
seal-mask
.a{fill-rule:evenodd;}techdegree
Henrik Christensen
Python Web Development Techdegree Student 38,322 Points

Hi Eric,

I like your website, it looks great! :-D Sometimes people forget making it looking good on both the computer and phone but your site seems to look good on both :-D

Can I ask how long you have been learning and where you get the inspiration? Cuz I seem to be stuck inspiration-wise :-/

Alexander Smith
Alexander Smith
10,476 Points

In my opinion, if you desired to work for a web developing company or as a freelancer, as i assume you do, as long as you answered their interview questions well they'd be stupid not to hire you with this fine presentation of work. Your site pretty much has it all. It's responsive, looks good but doesn't distract from the content, and showcases your portfolio in an appealing way that also shows off your knowledge. I'm not a professional web developer but i know enough to know when I see something special. Maybe others can offer helpful insight. I'm just an aspiring developer but I felt compelled to take time to write this in order to praise your work. Very well done!

Hello Eric,

Your website is designed very well. I don't have many suggestions besides replacing the hover animation of your menu and using an alternative method to show what section the user is currently on. However, this is really just a personal opinion. Also, for your footer area when you resize the browser window your profile picture's right margin becomes very small so the text looks a bit cramped. I feel that increasing the margins between the social media icons and the footer note would look better as well. Again, these are all pretty minor details. I really enjoyed scrolling down the Alfred Hitchcock Tribute, the aesthetics of that project is great. One last note, your weather checker link is broken, so you should probably fix that. But overall, your website looks quite professional. I hope this feedback was helpful to you!

Millan Singh
seal-mask
.a{fill-rule:evenodd;}techdegree
Millan Singh
Full Stack JavaScript Techdegree Student 8,392 Points

I'm going to break from the pack and provide you with a lot of criticism for this site. It's certainly not a bad site, but it is also a far-cry from what it could be, and there are some problems with it in terms of how it executes it's job: to show off your skills.

First, I wouldn't bother with the blog link unless you have something more than a basic github blog. Everything in your portfolio needs to be good, and if I was an employer and I clicked a link to your blog only to see a simple, boring Github blog whose content is just the stuff you've worked on, I would be turned off.

Second, you've got too much whitespace in the "about div" and "skills div". From what I can tell, that is caused by a static height (in the about div), which is unnecessary. Consider using height in "ems" instead. That way you can have the div's height be based on the font-size of the text inside it (make sure you set font-size in the div in CSS to make this work) and it will look good at all sizes.

For the skills section, remove the text that describes the skill. Any employer worth your time will know what HTML5, CSS3, and JS are; this is wasted space that prevents me, as a viewer, from getting to your projects sooner. Also, make all three icons smaller and put them next to each other; make this scale all the way down in screen size, so even on mobile I won't have to scroll a bunch.

In terms of your projects, you've definitely got some good ones, but some are definitely weaker than others. You really only need 3 or 4 projects here; pick the ones you are most proud of. I would say your Business Template, Hitchcock site, and Quote Space are your best ones, but please re-name the Business Template to something that sounds original. However, your Hitchcock site's top background-image doesn't work very well (I only see his head and the two birds) at my desktop resolution (1080p) and it's even worse at lower resolution. You may need to look into changing that up to make it more responsive.

Back to the actual portfolio site, the hamburger nav in mobile isn't effective in this case, not only because it clashes against the background, but it would be more effective as a static nav that's stuck to the top and has all the elements in the list rather than in the hamburger.

And finally, COLOR! God damn, the website's pallete is so boring. It works below with the projects, since the project thumbnails add color, but use the HTML/CSS/JS icons that have color at the very least. Full black and white can be a cool theme, but not in a portfolio.

So there you go. Hope this helps.