Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

Android Android Fragments Managing Fragments Fragment Flavors

Find Fragments By Tag

How do i correct my code,it's keep on saying: Remember to replace the FragmentManager.findFragmentById call with FragmentManager.findFragmentByTag

MainActivity.java
public class MainActivity extends AppCompatActivity implements NewsFragment.NewsListener {
    // New tags for referring to fragments
    public static final String NEWS_FRAGMENT = "news_fragment";
    public static final String NEWSITEM_FRAGMENT = "newsitem_fragment";


    @Override
    public void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);

        FragmentManager fragmentManager = getFragmentManager();

        NewsFragment savedFragment = (NewsFragment) fragmentManager.findFragmentById(R.id.placeholder);

        if (savedFragment == null) {
            NewsFragment newsFragment = new NewsFragment();
            FragmentTransaction fragmentTransaction = fragmentManager.beginTransaction();
            fragmentTransaction.add(R.id.placeholder, newsFragment,NEWS_FRAGMENT);

            fragmentTransaction.commit();
              NewsFragment tag = (NewsFragment) getFragmentManager().findFragmentByTag(NEWS_FRAGMENT);          
        }

    }

   @Override
    public void onNewsItemSelected(int index) {
        NewsItemFragment fragment = NewsItemFragment.createInstance(index);
        // TODO: how do we pass arguments to the new Fragment?

        FragmentManager fragmentManager = getFragmentManager();
        FragmentTransaction fragmentTransaction = fragmentManager.beginTransaction();
        fragmentTransaction.replace(R.id.placeholder, fragment);
        fragmentTransaction.addToBackStack(null);
        fragmentTransaction.commit();
         NewsItemFragment tag = ( NewsItemFragment)getFragmentManager().findFragmentByTag(MainActivity.NEWSITEM_FRAGMENT);
    }
}
NewsItemFragment.java
public class NewsItemFragment extends Fragment {
    public static final String KEY_NEWS_ITEM_INDEX = "news_item_index";

    @Override
    public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
        // TODO:  Hmmm, how do we get this index?
        int index = getArguments().getInt( NewsItemFragment.KEY_NEWS_ITEM_INDEX);
        getActivity().setTitle(News.headlines[index]);
        View view = inflater.inflate(R.layout.fragment_newsitem, container, false);
        return view;
    }

        public static NewsItemFragment createInstance(int index) {
        NewsItemFragment fragment = new NewsItemFragment();
        Bundle bundle = new Bundle();
        bundle.putInt(KEY_NEWS_ITEM_INDEX, index);
        fragment.setArguments(bundle);

        return fragment;
    }


    @Override
    public void onStop() {
        super.onStop();
        getActivity().setTitle(getResources().getString(R.string.app_name));
    }
}
News.java
public class News {
    public static String[] headlines = new String[]{
      "Treehouse student develops #1 App in Google App Store",
      "Oracle and Google decide to hug it out",
      "Java8 coming to Android!  Is it too late?"
    };
}

1 Answer

NewsFragment savedFragment = (NewsFragment) fragmentManager.findFragmentById(R.id.placeholder);

its this line you need to chacnge to findbyTag

yes and change the parameter (R.id.placeholder) with (NEWS_FRAGMENT), It works! Thank so much guys