First click, checkbox is broken. Then after, it works in reverse.

Question

I know I must be missing something but I can't figure out what.

I've gotten this far and there hasn't been any errors in the console. I haven't added any functionality to the edit button yet, but the delete button, the add button, works except for the user generated item. When I click on the checkbox, the item doesn't move down to the "completed" section for only the first click. Then, after that, it triggers the onchange event but then does it in reverse (moves it to the completed list when unchecked and incomplete when checked).

Here's the HTML:

<!DOCTYPE html>
<html>
  <head>
    <title>Todo App</title>
    <link href='http://fonts.googleapis.com/css?family=Lato:300,400,700' rel='stylesheet' type='text/css'>
    <link rel="stylesheet" href="css/style.css" type="text/css" media="screen" charset="utf-8">    
  </head>
  <body>
    <div class="container">
      <p>
        <label for="new-task">Add Item</label><input id="new-task" type="text"><button>Add</button>
      </p>

      <h3>Todo</h3>
      <ul id="incomplete-tasks">
        <li><input type="checkbox"><label>Pay Bills</label><input type="text"><button class="edit">Edit</button><button class="delete">Delete</button></li>
        <li class="editMode"><input type="checkbox"><label>Go Shopping</label><input type="text" value="Go Shopping"><button class="edit">Edit</button><button class="delete">Delete</button></li>

      </ul>

      <h3>Completed</h3>
      <ul id="completed-tasks">
        <li><input type="checkbox" checked><label>See the Doctor</label><input type="text"><button class="edit">Edit</button><button class="delete">Delete</button></li>
      </ul>
    </div>

    <script type="text/javascript" src="js/app.js"></script>

  </body>
</html>

Here is the JS:

<script>
//Problem: User interaction doesn't provide desired results.
//Solution: Add interactivity so the user can manage daily tasks. 

var taskInput = document.getElementById("new-task"); //new-task
var addButton =document.getElementsByTagName("button")[0]; //first button
var incompleteTasksHolder = document.getElementById("incomplete-tasks"); //incomplete-tasks
var completedTasksHolder = document.getElementById("completed-tasks"); //completed-tasks


//New Task List Item
var createNewTaskElement = function(taskString) {
  //create list item
  var listItem = document.createElement("li");

  //input checkbox
  var checkBox = document.createElement("input"); //checkbox
  //label
  var label = document.createElement("label");
  //input (text)
  var editInput = document.createElement("input"); //text
  //button.edit
  var editButton = document.createElement("button");
  //button.delete
  var deleteButton = document.createElement("button");

  //Each elements, needs modification
  checkBox.type = "checkbox";
  editInput.type = "text";

  editButton.innerText = "Edit";
  editButton.className = "edit";
  deleteButton.innerText = "Delete";
  deleteButton.className = "delete";

  label.innerText = taskString;

  //Each elements, needs appended
  listItem.appendChild(checkBox);
  listItem.appendChild(label);
  listItem.appendChild(editInput);
  listItem.appendChild(editButton);
  listItem.appendChild(deleteButton);

  return listItem;
}

//Add a new task
var addTask = function(){
  console.log("Add task…");
  //Create new list item with the text from #new-task:
  var listItem = createNewTaskElement(taskInput.value);
  //append listItem to incompleteTasksHolder
  incompleteTasksHolder.appendChild(listItem);
  bindTaskEvents(listItem, taskIncomplete);
}

//Edit an existing task
var editTask = function() {
  console.log("Edit task…");
  //When edit button pressed
    //if the parent li is in .editMode
      //Switch from .editMode
      //label text become the input's value
    //else
      //Switch to .editMode
      //input value becomes the label's text

    //toggle .editMode on the parent
}

//Delete an existing task
var deleteTask = function() {
  console.log("Delete task…");
  var listItem = this.parentNode;
  var ul = listItem.parentNode;

  //remove the parent list item from the ul
  ul.removeChild(listItem);
}

//Mark a task as complete
var taskCompleted = function() {
  console.log("Task Completed…");
  //append the task list item to the .completed-tasks
  var listItem = this.parentNode;
  completedTasksHolder.appendChild(listItem);
  bindTaskEvents(listItem, taskIncomplete);
}

//Mark a task as incomplete
var taskIncomplete = function() {
  console.log("Task incomplete…");
  //append to incompleted-tasks
  var listItem = this.parentNode;
  incompleteTasksHolder.appendChild(listItem);
  bindTaskEvents(listItem, taskCompleted);
}

var bindTaskEvents = function(taskListItem, checkBoxEventHandler) {
  console.log("Bind list item events");

  //select taskListItem's children
  var checkBox = taskListItem.querySelector("input[type=checkbox]");
  var editButton = taskListItem.querySelector("button.edit");
  var deleteButton = taskListItem.querySelector("button.delete");

  //bind editTask to edit button
  editButton.onclick = editTask;

  //bind deleteTask to delete button
  deleteButton.onclick = deleteTask;

  //bind checkbox to checkBoxEventHandler;
  checkBox.onchange = checkBoxEventHandler;
}

//Set click handler to the add task function
addButton.onclick = addTask;

//cycle over incompleteTaskHolder ul list items
for(var i=0; i < incompleteTasksHolder.children.length; i++){
  //bind events to list item's children (taskCompleted)
 bindTaskEvents(incompleteTasksHolder.children[i], taskCompleted); 
}


//cycle over completedTasksHolder ul list items
for(var i=0; i<completedTasksHolder.children.length; i++){
  //bind events to list item's children (taskIncomplete)
  bindTaskEvents(completedTasksHolder.children[i], taskIncomplete); 
}
</script>

Answer 1 · 2017-02-08T00:01:54Z

February 8, 2017 12:01am

You determine the checkbox functionality when you first add the item.

In the addTask function, the last thing you do is call bindTaskEvents. The second argument determines what will happen when the checkbox is first clicked. Right now you have taskIncomplete as that item. But since you start by adding the item to the incomplete list, you probably want the first action to be taskCompleted.

Once established, the actions toggle with each change.

Welcome to the Treehouse Community

Looking to learn something new?

louiecamacho

louiecamacho

First click, checkbox is broken. Then after, it works in reverse.

1 Answer

Steven Parker

Steven Parker

You determine the checkbox functionality when you first add the item.

louiecamacho

louiecamacho