Fix my 2 problems in my outrageous version of Guessing game !

Question

I didn't watch Kenneth's solution yet, so don't write here coding spoilers. I was making this alone for hours. Pretty proud about myself, but now I'm really stuck. Check 2 problems described in comments.

# pics random num between 1 and 10 - done
# asks user to guess - done
# when incorrect, tell user: too high, or too low - done
# let him guess again - done
# when it is right num, congratulate him - done
# limit his number of guesses - done
# tell him how many guesses he made - done
# differ from last try input - done
# differ from out of range inputs - done

# 1st problem:
# handle non integer inputs - !!!!!! - fail only on first input. It said: line 65, in <module>    if conToInt == rnd:NameError: name 'conToInt' is not defined
# I defined it, firstly with None (not worked), secondly with 0 (worked, but it made run IF condition about Below range print. I don't want it.

# 2nd problem:
# nofity user about duplicite inputs - !!!!! - list fail on second input, why !
# it said: line 45, in <module>    triedList = triedList.append(inp) AttributeError: 'NoneType' object has no attribute 'append'





import random

maxTry = 500

fromNum = 9     # range included
toNum = 999     # range included       

print('Guess a number between {} and {} (both included) !'.format(fromNum, toNum))
print('You may guess {} times.'.format(maxTry))

rnd = random.randint(fromNum, toNum)

count = 0

# 1st problem: conToInt = 0

triedList = []

while count < maxTry:
    inp = input('> ')
    count = count + 1
    conToStr = str(count)
    lastInd = len(conToStr)
    finalInt = int(conToStr[lastInd - 1])
    # 2nd problem: triedList = triedList.append(inp)

    try:
        conToInt = int(inp)
    except:
        print("Hey ! A number, that's you have to put in !")
        print('You wasted an attempt for this mistake ...')

    if count == 11:
        print('This was your {} attempt.'.format(conToStr + 'th'))
    elif finalInt == 1:
        print('This was your {} attempt.'.format(conToStr + 'st'))
    if count == 12:
        print('This was your {} attempt.'.format(conToStr + 'th'))        
    elif finalInt == 2:
        print('This was your {} attempt.'.format(conToStr + 'nd'))
    if count == 13:
        print('This was your {} attempt.'.format(conToStr + 'th'))        
    elif finalInt == 3:
        print('This was your {} attempt.'.format(conToStr + 'rd'))
    if finalInt >= 4:
        print('This was your {} attempt.'.format(conToStr + 'th'))
    if finalInt == 0:
        print('This was your {} attempt.'.format(conToStr + 'th'))
    if conToInt == rnd:
        print('Congratulations ! You have got it !!!')
        break
    if conToInt < fromNum:
        print('Hey ! You are out of the range (below) !!')
        if count != maxTry:
            print('You wasted an attempt for this mistake ... Try again !')
        if count == maxTry:
            print('You wasted an attempt for this mistake ... GAME OVER')
    elif conToInt < rnd:
        print('Incorrect: too low.  Try again !')        
    if conToInt > toNum:
        print('Hey ! You are out of the range (above) !!')
        if count != maxTry:
            print('You wasted an attempt for this mistake ... Try again !')
        if count == maxTry:
            print('You wasted an attempt for this mistake ... GAME OVER')
    elif conToInt > rnd:
        print('Incorrect: too high.  Try again !')

Answer 1 · 2015-02-04T02:49:02Z

February 4, 2015 2:49am

First problem: When the try block fails, you don't make any assignment to conToInt, so the previous value is still there. When that value is an initial value of None, the code breaks. When that value is an initial value of 0, it prints the "below range" message because 0 is below the range. Otherwise, the value is the same as the last guess. There are many ways to solve this, but the quickest way would be to put a continue statement as the last line of your except block.

Second problem: triedList.append modifies the list in-place, instead of returning a copy with the new data. The first time you call triedList = triedList.append(inp), it sets the value of triedList to the return of .append, which is None. The second time the line is run, triedList is already None, hence the error 'NoneType' object has no attribute 'append'. Simply removing the first part of the line and leaving triedList.append(inp) will solve that problem.

My thoughts: It's good to alternate between learning new things, and pushing your abilities with the things you already know. You should be proud for creating this game with such basic techniques, but now it is time for you to learn some more advanced python (or javascript, or ruby, whereever else this journey might take you). For instance, once you learn to use a switch block, you can say goodbye to those huge sections of if/elif/else statements, and I bet you won't miss them. Have fun!

Answer 2 · 2015-02-05T05:53:43Z

February 5, 2015 5:53am

If I understand you, my solution to problem 1 wasn't what you wanted because you want it to print 'This was your {} attempt.' even if they didn't enter a number. Here is one way to do that with what you know. Instead of putting continue directly in the except block, try this:

try:
    conToInt = int(inp)
except:
    contToInt = None
    print("Hey ! A number, that's you have to put in !")
    print('You wasted an attempt for this mistake ...')

...then after you print the attempt number, but before you try to use conToInt, do this:

if conToInt == None: continue

You also won't need to give conToInt an initial value since it will always get a value.

If you want to know how to make the whole thing even shorter and simpler, just ask. I don't know if you want me to tell you, so I'm only answering your two problems.

Answer 3 · 2015-02-05T22:31:48Z

February 5, 2015 10:31pm

Oops, I wrote contToInt instead of conToInt above, that's why it didn't work. Here is what I meant, and it works:

import random

maxTry = 500

fromNum = 9     # range included
toNum = 999     # range included       

print('Guess a number between {} and {} (both included) !'.format(fromNum, toNum))
print('You may guess {} times.'.format(maxTry))

rnd = random.randint(fromNum, toNum)

count = 0

triedList = []

while count < maxTry:
    inp = input('> ')
    count = count + 1
    conToStr = str(count)
    lastInd = len(conToStr)
    finalInt = int(conToStr[lastInd - 1])
    triedList.append(inp)

    try:
        conToInt = int(inp)
    except:
        conToInt = None
        print("Hey ! A number, that's you have to put in !")
        print('You wasted an attempt for this mistake ...')


    if count == 11:
        print('This was your {} attempt.'.format(conToStr + 'th'))
    elif finalInt == 1:
        print('This was your {} attempt.'.format(conToStr + 'st'))
    if count == 12:
        print('This was your {} attempt.'.format(conToStr + 'th'))        
    elif finalInt == 2:
        print('This was your {} attempt.'.format(conToStr + 'nd'))
    if count == 13:
        print('This was your {} attempt.'.format(conToStr + 'th'))        
    elif finalInt == 3:
        print('This was your {} attempt.'.format(conToStr + 'rd'))
    if finalInt >= 4:
        print('This was your {} attempt.'.format(conToStr + 'th'))
    if finalInt == 0:
        print('This was your {} attempt.'.format(conToStr + 'th'))

    if conToInt == None:
      continue

    if conToInt == rnd:
        print('Congratulations ! You have got it !!!')
        break
    if conToInt < fromNum:
        print('Hey ! You are out of the range (below) !!')
        if count != maxTry:
            print('You wasted an attempt for this mistake ... Try again !')
        if count == maxTry:
            print('You wasted an attempt for this mistake ... GAME OVER')
    elif conToInt < rnd:
        print('Incorrect: too low.  Try again !')        
    if conToInt > toNum:
        print('Hey ! You are out of the range (above) !!')
        if count != maxTry:
            print('You wasted an attempt for this mistake ... Try again !')
        if count == maxTry:
            print('You wasted an attempt for this mistake ... GAME OVER')
    elif conToInt > rnd:
        print('Incorrect: too high.  Try again !')

But there are still many things you can do to improve your code. For instance, when you reach the 111th attempt, it prints 111st instead. You can fix that, and make your code smaller and more readable, and eliminate three variables from the while block by defining a function, like this:

def printAttempt(count):
  countStr = str(count)
  suffix = 'th'
  if count%100 < 10 or count%100 > 20:
    if countStr[-1] == '1': suffix = 'st'
    if countStr[-1] == '2': suffix = 'nd'
    if countStr[-1] == '3': suffix = 'rd'
  print ('This was your {} attempt'.format( countStr + suffix ))

Then, instead of that first big block of if/elif statements, you can just call printAttempt(count)

I think you've done great with what you know, but if you take some more classes and learn some new features, everything will get much easier. Then you can make an even cooler project. I am leaving treehouse for a while after today, because I need to save money, but I wish you good luck in your studies.

Answer 4 · 2015-02-07T20:51:29Z

February 7, 2015 8:51pm

this forum is so dead I wonder why is this paysite...

I can't wait 24 hours for every next answer ...

Answer 5 · 2015-02-09T10:59:44Z

February 9, 2015 10:59am

I have made it ! It's hilarious, muahaha !

import random

maxTry = 500

fromNum = 1     # range included
toNum = 999     # range included       

print('Guess a number between {} and {} (both included) !'.format(fromNum, toNum))
print('You may guess {} times.'.format(maxTry))

rnd = random.randint(fromNum, toNum)

count = 0

triedList = []

while count < maxTry:
    inp = input('> ')
    count = count + 1
    conToStr = str(count)
    lastInd = len(conToStr)
    finalInt = int(conToStr[lastInd - 1])
    if inp in triedList:
        print('You have it already put it before !')
    triedList.append(inp)

    try:
        conToInt = int(inp)
    except:
        conToInt = None 
        print("Hey ! A number, that's you have to put in !")
        print('You wasted an attempt for this mistake ...')

    # managing ordinal numbers during count changing
    # 1, 11
    if count == 1:                                                      # 1
        print('This was your {} attempt.'.format(conToStr + 'st'))
    elif count == 11:                                                   # 11
        print('This was your {} attempt.'.format(conToStr + 'th'))
    elif lastInd == 2 and conToStr[-1] == '1' and conToStr[-2] != '1':  # 21, 31, ...
        print('This was your {} attempt.'.format(conToStr + 'st'))
    elif lastInd > 2 and conToStr[-1] == '1' and conToStr[-2] != '1':   # 101, 201, ...
        print('This was your {} attempt.'.format(conToStr + 'st'))
    elif lastInd > 2 and conToStr[-1] == '1' and conToStr[-2] == '1':   # 111, 211, ...
        print('This was your {} attempt.'.format(conToStr + 'th'))
    # 2, 12
    if count == 2:                                                      # 2
        print('This was your {} attempt.'.format(conToStr + 'nd'))
    elif count == 12:                                                   # 12
        print('This was your {} attempt.'.format(conToStr + 'th'))
    elif lastInd == 2 and conToStr[-1] == '2' and conToStr[-2] != '1':  # 22, 32, ...
        print('This was your {} attempt.'.format(conToStr + 'nd'))
    elif lastInd > 2 and conToStr[-1] == '2' and conToStr[-2] != '1':   # 102, 202, ...
        print('This was your {} attempt.'.format(conToStr + 'nd'))
    elif lastInd > 2 and conToStr[-1] == '2' and conToStr[-2] == '1':   # 112, 212, ...
        print('This was your {} attempt.'.format(conToStr + 'th'))    
    # 3, 13
    if count == 3:                                                      # 3
        print('This was your {} attempt.'.format(conToStr + 'rd'))
    elif count == 13:                                                   # 13
        print('This was your {} attempt.'.format(conToStr + 'th'))
    elif lastInd == 2 and conToStr[-1] == '3' and conToStr[-2] != '1':  # 23, 33, ...
        print('This was your {} attempt.'.format(conToStr + 'rd'))
    elif lastInd > 2 and conToStr[-1] == '3' and conToStr[-2] != '1':   # 103, 203, ...
        print('This was your {} attempt.'.format(conToStr + 'rd'))
    elif lastInd > 2 and conToStr[-1] == '3' and conToStr[-2] == '1':   # 113, 213, ...
        print('This was your {} attempt.'.format(conToStr + 'th'))
    # all other
    if count not in [1, 11, 2, 12, 3, 13] and conToStr[-1] not in ['1', '2', '3']:
        print('This was your {} attempt.'.format(conToStr + 'th'))

    if conToInt == None:
      continue
    if conToInt == rnd:
        print('Congratulations ! You have got it !!!')
        break
    if conToInt < fromNum:
        print('Hey ! You are out of the range (below) !!')
        if count != maxTry:
            print('You wasted an attempt for this mistake ... Try again !')
        if count == maxTry:
            print('You wasted an attempt for this mistake ... GAME OVER')
    elif conToInt < rnd:
        print('Incorrect: too low.  Try again !')        
    if conToInt > toNum:
        print('Hey ! You are out of the range (above) !!')
        if count != maxTry:
            print('You wasted an attempt for this mistake ... Try again !')
        if count == maxTry:
            print('You wasted an attempt for this mistake ... GAME OVER')
    elif conToInt > rnd:
        print('Incorrect: too high.  Try again !')

Josiah McClellan: Sorry, I though that suffix, is a python keyword like str.suffix. Sorry for that Jesus..... Now I see, it is normal beginners concept Me stupid

Welcome to the Treehouse Community

Looking to learn something new?

silashunter

silashunter

Fix my 2 problems in my outrageous version of Guessing game !

silashunter

silashunter

panic

5 Answers

Josiah McClellan

Josiah McClellan

silashunter

silashunter

silashunter

silashunter

silashunter

silashunter

2nd problem solved. I just changed line of my code up way in order.

1st problem solved too ! But in very bad way. I guess, in real world programming an apps, this is not acceptable.

Is there better way to solve it?

Josiah McClellan

Josiah McClellan

silashunter

silashunter

Josiah McClellan

Josiah McClellan

silashunter

silashunter

silashunter

silashunter

silashunter

silashunter