Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

CSS

float:left is causing the social media icons to move next to first image on the top.

Even though the footer is outside the #wrapper ,#gallery , the settings of float is being applied to the gallery and the footer. Can you explain how it functions and how to correct it?

<body>
    <header>
      <a href="index.html" id="logo">
      <h1>Kosha India</h1>
      <h2> Indian Store</h2>
      </a>
      <nav>
        <ul>
          <li><a href="index.html" class="selected">Shop</a></li>
          <li><a href="About.html">About</a></li>
          <li><a href="contact.html">Contact</a></li>
        </ul>
      </nav>
    </header>
    <div id="wrapper">
      <section>
        <ul id="gallery">
          <li>
            <a href="img/numbers-01.jpg">
              <img src="img/numbers-01.jpg" alt="">
              <p> Experiment with colors and texture</p>
            </a>

            <a href="img/numbers-02.jpg">
              <img src="img/numbers-02.jpg" alt="">
              <p> Experiment with colors and texture</p>
            </a>

            <a href="img/numbers-06.jpg">
              <img src="img/numbers-06.jpg" alt="">
              <p> Experiment with colors and texture</p>
            </a>

            <a href="img/numbers-09.jpg">
              <img src="img/numbers-09.jpg" alt="">
              <p> Experiment with colors and texture</p>
            </a>

            <a href="img/numbers-12.jpg">
              <img src="img/numbers-12.jpg" alt="">
              <p> Experiment with colors and texture</p>
            </a>
          </li>
        </ul>
      </section>
     </div>
    <footer>
      <a href="https://twitter.com/KoshaIndia"><img src="img/twitter-wrap.png" alt="Twitterlogo"></a>
      <a href="https://www.facebook.com/profile.php?id=100012075392030"><img src="img/facebook-wrap.png" alt="Facebook logo"></a>
      <p>&copy; 2016 Kosha India</p>
    </footer>  
 </body>

Relevant CSS

img{
max-width:100%;
}

#wrapper{
  max-width:940px;
  margin: 0 auto;
  padding:0 5%;
}

#gallery{
margin:0;
padding:0;
list-style: none;   /*remove any bullet points*/
}

#gallery li {
float:left;
width:45%;
margin:2.5%;
background-color:#f5f5f5;
color:#bdc3c7;
}

<!DOCTYPE html> <html>

<head> <meta charset="utf-8"> <title>Kosha India | Indian Store</title> <link rel="stylesheet" href="css/normalize.css"> <link href="https://fonts.googleapis.com/css?family=Changa+One|Open+Sans" rel="stylesheet"> <link rel="stylesheet" href="css/main.css"> </head> <body> <header> <a href="index.html" id="logo"> <h1>Kosha India</h1> <h2> Indian Store</h2> </a> <nav> <ul> <li><a href="index.html" class="selected">Shop</a></li> <li><a href="About.html">About</a></li> <li><a href="contact.html">Contact</a></li> </ul> </nav> </header> <div id="wrapper"> <section> <ul id="gallery"> <li> <a href="img/numbers-01.jpg"> <img src="img/numbers-01.jpg" alt=""> <p> Experiment with colors and texture</p> </a>

        <a href="img/numbers-02.jpg">
          <img src="img/numbers-02.jpg" alt="">
          <p> Experiment with colors and texture</p>
        </a>

        <a href="img/numbers-06.jpg">
          <img src="img/numbers-06.jpg" alt="">
          <p> Experiment with colors and texture</p>
        </a>

        <a href="img/numbers-09.jpg">
          <img src="img/numbers-09.jpg" alt="">
          <p> Experiment with colors and texture</p>
        </a>

        <a href="img/numbers-12.jpg">
          <img src="img/numbers-12.jpg" alt="">
          <p> Experiment with colors and texture</p>
        </a>
      </li>
    </ul>
  </section>
 </div>
<footer>
  <a href="https://twitter.com/KoshaIndia"><img src="img/twitter-wrap.png" alt="Twitterlogo"></a>
  <a href="https://www.facebook.com/profile.php?id=100012075392030"><img src="img/facebook-wrap.png" alt="Facebook logo"></a>
  <p>&copy; 2016 Kosha India</p>
</footer>

</body>

</html>

/****************************** General ******************************/

body{ font-family:'Open Sans",sans-serif; }

/* To remove all the underlines on our links*/ a{ text-decoration:none; }

img{ max-width:100%; }

/* To select an id use #, eg: <div id=wrapper. This is to put the contEnts in a boundary and make special changes to them*/

wrapper{

max-width:940px; margin: 0 auto; padding:0 5%; }

/****************************** Heading ******************************/

/* to change the proerties of the logo (id lodo is assigned to header in html file)*/

logo{

text-align: center; margin:0;
}

h1{ font-family:'Changa One',sans-serif; margin:15px 0; font-size:1.75em; line-height:0.8em; }

h2{ font-size:0.75em; margin:-5px 0 0; font-weight: normal; /unbolds the font/ }

/****************************** Navigation ******************************/ nav{ text-align:center; padding:10px 0; margin:20px 0 0;
}

/************************ FOOTER ************************/

footer{ font-size:0.75em; text-align:center; padding-top:50px; color:#ccc; }

/***************************** Page Shop *****************************/

gallery{

margin:0; padding:0; list-style: none; /remove any bullet points/ }

gallery li {

float:left; width:45%; margin:2.5%; background-color:#f5f5f5; color:#bdc3c7; }

/****************************** COLOUR ******************************/

/site body/

body{ background-color:#fff; color:#999; } /* green header*/ header{ background:#6ab47b; border-color:#599a68; }

/* nav background on mobile devices*/ nav{ background:#599a68; } /* logo text*/ h1,h2{ color:#fff; } /* changing colours using hexa decimal color system for all the links*/

a{ color:#6ab47b; }

/:visited is a pseudo class . for more info:https://developer.mozilla.org/en-US/docs/Web/CSS/Pseudo-classes. changed colour/

nav a, nav a:visited{ color:#fff; }

/* selected is a class in header element in html file. element with class selected will have following css properties*/

nav a.selected, nav a:hover{ color:#32673f; }

2 Answers

Emily Carey
Emily Carey
7,954 Points

Without knowing what you're actually trying to achieve it's hard to establish why you need to use float at all... All i will say is that the parent to your li's is collapsing as you have no clearfix in place. If you need to use float to achieve what you need in this scenario then read up about clearfix, it's the only way to handle floats to avoid all the aggro that comes along with it. I personally try every other avenue before i need to resort to floats, as they can cause trouble when debugging why your layout/styles aren't showing how what you expected.

Oliver Hayman
Oliver Hayman
8,168 Points

Credit goes to Zette Harbour from this thread for this one but I've found the following to work:

footer {
  font-size: 0.75em;
  text-align: center;
  clear: both;
  padding-top: 50px;
  color: #ccc;
}