Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

CSS

Posted by Eric Cline
Eric Cline
1,769 Points

Fluid Layout Feedback

I've sketched a simple fluid layout (potentially for a blog) with some min-widths so things don't get too squished with a tiny window. I'd love some feedback on it since it's often too easy to admire your own handiwork. http://codepen.io/ericcline/pen/Imejk

I learned a ton about why mixing pixels and percents is a bad idea. : )

2 Answers

Ram Ada
Ram Ada
360 Points
Ram Ada
Ram Ada
360 Points

Perhaps consider a gradient background instead of a solid color? http://subtlepatterns.com/snacks/

The .header h1:hover { text-shadow } looks a bit odd against the grey background. I would consider a different color.

.sidebar a:hover { text- shadow) the grey is slightly hard to to see against the grey background.

These are just some suggestions :)

Eric Cline
Eric Cline
1,769 Points

Thanks for the feedback! Nothing about the color scheme is set in stone. I have changed it a dozen times already, just to try different things. Mostly, it was an exercise in designing the layout and getting all my boxes to play nice together.

Max Hallinan
Max Hallinan
7,614 Points
Max Hallinan
Max Hallinan
7,614 Points

The blue and grays go nicely together. I have one suggestion and one question. My suggestion is to give your paragraphs a max-width so the measure is prevented from getting too long. My question is why give the header h1 a hover state? This effect creates the expectation of further interactivity where there is none.